Giter Club home page Giter Club logo

Comments (8)

VVD avatar VVD commented on August 25, 2024

Why did you closed it?

from ktx.

mr0wnage avatar mr0wnage commented on August 25, 2024

in my opinion it works not right
it always reset to 1 after map change, can be fixed by put 'set k_teamoverlay "0"' to in ktx/configs/usermodes/default.cfg it should work.

from ktx.

mushis avatar mushis commented on August 25, 2024

so... put 'set k_teamoverlay "0"' to in ktx/configs/usermodes/default.cfg works?

from ktx.

mr0wnage avatar mr0wnage commented on August 25, 2024

yeah it works...
but 'set k_teamoverlay "0"' in ktx.cfg didnt work

it must be installed every time the map starts
this is wrong in my opinion

from ktx.

mushis avatar mushis commented on August 25, 2024

well, imo the behavior should be remember the last setting until all the settings are reset.

Removing the k_teamoverlay setting in default configs should be enough to do this. but in my tests, it wasn't (tested nquakesv windows). So this should be the issue here.

looking at the code, at this block in commands.c :
// common settings for all user modes const char common_um_init[] =
there's a bunch of settings, including "k_teamoverlay 1\n"
which might be the issue here. So i've tested it, compiled KTX without that line, and everything worked as intended.

image

So the fix is 2 things:

  • change usermodes/default.cfg
  • change commands.c

from ktx.

VVD avatar VVD commented on August 25, 2024

Keep it on by default in default.cfg, but remove from reset code in commands.c.

from ktx.

deurk avatar deurk commented on August 25, 2024

Changed in 2b0681e, now reset to 0 by default, unless default.cfg says otherwise, which I think is the intended goal.

from ktx.

mushis avatar mushis commented on August 25, 2024

@deurk the commit link shows weird characters. are you sure its ok and there's no encoding issue?

edit: nevermind, saw #66 now

from ktx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.