[Bug]: Issue with Brain Creation and URL Knowledge Addition about quivr HOT 1 OPEN

🤖

Hey @andrea-garritano! Great to see you back here. Hope you're doing well.

Thank you for reporting this issue. Based on the information you've provided, it seems like the problem might be related to the asynchronous nature of the handleFeedBrain function, which is responsible for uploading files and crawling URLs. This function is called within the createBrain function, but it's invoked with the void keyword, which means that the createBrain function doesn't wait for handleFeedBrain to finish before it continues executing.

Here's the relevant code:

if (brain_type === "doc") {
  void handleFeedBrain(createdBrainId);
}

If handleFeedBrain encounters an error or takes longer than expected, the rest of the createBrain function might execute before the brain is fully created, leading to the page refresh and failure to create a new Brain entity.

A potential solution could be to await the handleFeedBrain function:

if (brain_type === "doc") {
  await handleFeedBrain(createdBrainId);
}

This will ensure that the createBrain function waits for handleFeedBrain to finish before it continues, which might resolve the issue. However, please note that this is just a hypothesis based on the provided code and might not be the actual cause of the problem.

You can find the relevant code in the useBrainCreationApi.ts file.

As for the handleFeedBrain function, it's an asynchronous function that takes an object with brainId and chatId as parameters. The function is responsible for handling the feeding of knowledge to the brain. It creates an array of promises (uploadPromises) by mapping over the files array and calling the uploadFileHandler function for each file, passing the file, brainId, and chatId as arguments. It also creates another array of promises (crawlPromises) by mapping over the urls array and calling the crawlWebsiteHandler function for each URL, passing the URL, brainId, and chatId as arguments. It then waits for all the promises in the uploadPromises array, crawlPromises array, and the updateOnboardingA function to resolve using Promise.all.

You can find the relevant code in the useFeedBrainHandler.ts file.

I hope this helps! If you have any further questions or need more clarification, please don't hesitate to ask.

-Dosu

Sources

• frontend/lib/components/AddBrainModal/components/AddBrainSteps/components/BrainKnowledgeStep/hooks/useBrainCreationApi.ts
• frontend/app/brains-management/[brainId]/components/BrainManagementTabs/components/KnowledgeOrSecretsTab/components/AddKnowledge/hooks/useFeedBrainHandler.ts

This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

from quivr.