Comments (3)
I looked into this a bit more, and this isn't unique to our case; others also want to unit/mock test the go-github library. We should check out if we can use the go-github-mock library.
from quickfeed.
That said, we are already using the github.com/steinfletcher/apitest library for some other github/web/auth testing.
from quickfeed.
Turns out the original MockSCM implementation is used by the web package to test things as well; so it is useful for that. But we should rewrite it so that requests and responses go through the GithubSCM implementation, instead of the MockSCM.
Turns out that we don't really need the go-github-mock library; we only need a few minor things from it and we can use the stdlib http.ServeMux
and PathValue
instead.
from quickfeed.
Related Issues (20)
- Lab information in Result view gets hidden at bottom or squashed when test name is long
- Log details view is cut off short; it could expand to the bottom of the result view portion HOT 2
- Unable to delete a group that has not been approved
- Display percentage impact of individual tests based on score and weight
- Groups with similar names are "merged" on GitHub
- Approvelist support now requires manual steps to enable support for PATs HOT 1
- Avoid calling go list to find quickfeed's root folder
- approvelist: may display too many approved assignments
- Remove team creation on github to simplify management of groups
- chore: Void comment no longer relevant and can be removed
- chore: Remove excessive use of gorm uniqueIndex
- chore: rename RepositoryOptions.Path to Repo
- chore: replace db.CreateCourse and with its qtest counterpart
- chore: fix deprecated docker types
- chore: remove unused scm.Authorization
- chore: consider to remove scm.GetRepositories
- chore: remove unused field CreateRepositoryOptions.Permission
- chore: avoid accessing protobuf message type fields directly
- chore: consider adding setters for oneof fields
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from quickfeed.