Add an option to delete VMs? about quickgui HOT 12 CLOSED

I did have this thought, the could be a "bin" button next to the play/stop buttons on the manager screen to delete the VM (with a confirmation step).

However, what should this button do? quickemu --vm vm.conf --delete exists, but it just deletes the disk image. Should we just be exposing that behaviour, or should we completely delete the VM directory and .conf file?

from quickgui.

If we draw a parallel with what a file explorer does, simply "deleting" a file just puts it in the trash, it doesn't remove the file completely.
So I would tend to thing a "delete" button would just delete the disk and variables, leaving the config intact. Maybe the UI could show up an icon or a different color when it does not detect a disk ? That would also bring attention to newly created VMs, when the use comes back from the downloader.

from quickgui.

However, what should this button do? quickemu --vm vm.conf --delete exists, but it just deletes the disk image. Should we just be exposing that behaviour, or should we completely delete the VM directory and .conf file?

Perhaps quickemu needs to expand the delete functionality?

• --delete disk to just delete the virtual hard drive and EFI variables.
• --delete vm to delete everything.

And deprecate --delete to just explain the two options above.

from quickgui.

Generally speaking, I'm in favour of the principle that the GUI should expose quickemu's functionality, rather than add to it or reimplement it. If we're going to add a "full delete" option, I'd agree with @flexiondotorg's suggestion of adding it to quickemu first.

Regarding the UI, I think something like the below would be good:

from quickgui.

I have no objection, that sounds like the right thing to do.

from quickgui.

I've added --delete-disk and --delete-vm options to quickemu 2.3.3 which was released earlier today. The existing --delete is now an alias for --delete-disk.

from quickgui.

@diddledani I've pushed this to branch wip20, give it a go and let me know if you've got any feedback.

from quickgui.

@diddledani I've pushed this to branch wip20, give it a go and let me know if you've got any feedback.

It actually got mingled in with #52 last night

from quickgui.

How embarassing. Oh well, I'm happy enough with how it works for now, Hopefully the changes of someone running with an old version of quickemu are minimal. I think we can mark this closed, and open a new issue for any improvements.

from quickgui.

Yeah, sorry I didn't catch that up earlier. I didn't want to mess with my already very messy merge :P

from quickgui.

@ymauray I dont seem to have permission to close issues, could you grant it for me?

from quickgui.

Wimpy made us both owners now :)

from quickgui.