Giter Club home page Giter Club logo

Comments (5)

stuartwdouglas avatar stuartwdouglas commented on July 17, 2024

I don't think this is actually an issue, if I had thought about it at all I would have realised that this is the fix: 971f195

from quarkus.

mkouba avatar mkouba commented on July 17, 2024

Hm, I still don't understand what the problem was. AbstractGenerator.getBaseName() was only used when generating a name for client proxies and intercepted subclasses. Neither of these is generated for BeanManager built-in bean. Anyway, I think it would make sense to change the suffix to something like _$Bean etc.

from quarkus.

stuartwdouglas avatar stuartwdouglas commented on July 17, 2024

The issue is that if the user application has a class with _Bean in the name it would break (this happened when I added the signature to the name to give stable names). Changing to lastIndexof fixes this.

from quarkus.

mkouba avatar mkouba commented on July 17, 2024

I see and thanks for the explanation ;-). I'd leave this open for now. With very low priority.

from quarkus.

stuartwdouglas avatar stuartwdouglas commented on July 17, 2024

I think just close it, it's not a problem now.

from quarkus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.