Giter Club home page Giter Club logo

Comments (3)

designsters avatar designsters commented on July 17, 2024

@Earlz It is ethereum rule that imposes such behavior
https://github.com/qtumproject/cpp-eth-qtum/blob/1351a89ffb5fa3e1749ce31fa0c02396bdf71c48/libethereum/Executive.cpp#L185

Transactions with gas limit that exceeds block's gas limit will cause out of gas exception because of EVM design.

from qtum.

Earlz avatar Earlz commented on July 17, 2024

This behavior can be an attack vector though in our case. A miner could fill up their own block with gas using transactions and then mine every contract execution (without actually doing any processing) and get gas from it due to the out of gas condition

We need to change the miner logic so that if a transaction causes the block to run out of gas, then the transaction should be kicked out of the block, rather than the transaction getting an out of gas exception. And we should change consensus logic so that a block that has a transaction that causes the block to exceed it's gas limit will make the entire block invalid with a DoS error

from qtum.

Earlz avatar Earlz commented on July 17, 2024

Will be fixed in future story (not a bug, but rather a missing feature)

from qtum.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.