BIP34 scriptSig error at block 1 due to activation from genesis. about qtum HOT 11 CLOSED

I think this might be easiest to fix by just having BIP34 not start until after block 16

from qtum.

It bugs out if setting BIP34Height = 0, but not when setting BIP34Height = 1

from qtum.

same here. this resolve my issue for a new altcoin. thanks!

        consensus.BIP34Height = 1;
        consensus.BIP34Hash = uint256S("");

from qtum.

Well better see why it's happening, starting from block 16 would entail having block hashes until 16 known, which is not convenient at the current state where the genesis hash itself is still subject to possible changes.

from qtum.

I have updated the issue: after retesting I am not able to reproduce the issue when setting BIP34 activation from block >= 1 instead of 0. The issue relating to blocks after that appear to have been due to issues in the python qa tests that I mistook for the same issue.

from qtum.

Oh I see, so it bugs out for the genesis, but not block 1 (after genesis) ?

from qtum.

That seems like an easy fix then. I assume this is because the genesis block isn't constructed to be compliant with BIP34. I don't think there is any benefit to complicating the genesis block generation for that

from qtum.

Ah yes, that seems to be the cause of the issue.

from qtum.

Yes, makes more sense, I will fix it.

from qtum.

Pull request created: #16

from qtum.

fixed and merged

from qtum.