Comments (8)
I understand. I just think that Deptrac was very nicely customizable and extendable thanks to its event-driven design and the fact you have access to its DIC. That allowed us some neat customizations we needed. And now it got a bit worse :)
from deptrac.
Yeah, I know the risk and I'm willing to take it. Obviously I'm doing non-standard thing, I just wanna let you know that there are deptrac users that utilize its internal stuff.
from deptrac.
By the way, with the new release model, I can release new version quicker! And I will try do release Deptrac more often!
My next goal is to figure out how we deploy the documentation 😅.
from deptrac.
I’ve merged ‘Deptrac_Internal’ as the namespace prefix for Deptrac a dependencies.
See https://github.com/qossmic/deptrac-src/pull/48/files.
There is not a release wirh the static prefix, so there is still the possibility to change it.
from deptrac.
I don’t think that the internal dependencies have ever been a public api. Properly a better solution would be to have a official extension point which is provided by Deptrac itself.
another option could be to prefix the dependencies with a static prefix. And people could still use those.
from deptrac.
With using the Symfony event from Deptrac your project adds a dependency. And if Deptracs decides to drop the Symfony stuff your code will break.
long story short: Deptrac should define extension points and document them. Maybe that’s already the case @patrickkusebauch ?
from deptrac.
I think a nice middle ground would be to have a static prefix for the Symfony Event Dispatcher, something like Deptrac\Symfony\Component\EventDispatcher\EventSubscriberInterface
. That way the users can depend on a consistent name to extend that would not break between releases.
@janedbal do you think that would be good enough for your use case?
from deptrac.
If you insist on prefixing, then static one is definitelly better. Thank you
from deptrac.
Related Issues (20)
- Uncaught Error: Typed property Qossmic\Deptrac\Core\Ast\AstMap\DependencyToken::$context must not be accessed before initialization HOT 3
- Does `functionName` only support functions with namespaces? HOT 2
- Cannot configure skipViolations with DeptracConfig HOT 1
- Problem with duplicate functions and classes HOT 1
- PHP Fatal error on v2.0 (EventHelper::__construct(): Argument #1 ($skippedViolations) must be of type array, null given) HOT 3
- PHP Warning: Undefined array key "internal_tag" HOT 5
- Unable to customize DIC services since 2.0
- composer doesn't allow to check exclusion from one of the packages HOT 2
- Option --version does not show correct version - ^2.0 HOT 2
- v2.0.0 includes unnecessary files HOT 1
- Upgrade guide is not up to date on the website HOT 1
- Option --report-uncovered placed before --config-file makes deptrac ignore the provided configuration file HOT 2
- Upgrade Php-Parser from 4 to 5 HOT 1
- outdated docs HOT 3
- Warning: Undefined array key "internal_tag" in DependsOnInternalToken.php HOT 3
- Github-Action for deployment
- DX: misleading error messages
- Formatter "graphviz-dot" generating different files on same code base HOT 2
- ComposerCollector doesn't allow to check exclusion from one of the packages HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from deptrac.