Comments (4)
This kind of begs the question, what should be the base
path that this collector should look at in case a relative path to the file is provided?
from deptrac.
Did you @patrickkusebauch or @dbrumann discussed, what deptrac sees as its base
path?
- the users current dir?
- the path of the deptrac executable?
- the paht of the deptrac-config?
In the code I have seen Parameters for currentWorkingDirectory
and projectDirectory
and both get getcwd()
assigned.
The documentations says:
* `%currentWorkingDirectory%` The path Deptrac runs in
* `%projectDirectory%` The path where the configuration is stored.
But what I see in the code is:
if (false === ($currentWorkingDirectory = getcwd())) {
throw CannotGetCurrentWorkingDirectoryException::cannotGetCWD();
}
....
$factory = new ServiceContainerBuilder($currentWorkingDirectory);
public function build(): ContainerBuilder
{
$container = new ContainerBuilder();
$container->setParameter('currentWorkingDirectory', $this->workingDirectory);
self::registerCompilerPasses($container);
self::loadServices($container, $this->cacheFile);
$container->registerExtension(new DeptracExtension());
$container->setParameter('projectDirectory', $this->workingDirectory);
if (null !== $this->configFile) {
self::loadConfiguration($container, $this->configFile);
}
$container->compile(true);
return $container;
}
I could work on this problem as soon as I understand the path
situation. Btw it's also relevant for the #1078, I think.
from deptrac.
Nope, we didn't.
from deptrac.
This kind of begs the question, what should be the
base
path that this collector should look at in case a relative path to the file is provided?
I would say, relative to the config-file
.
from deptrac.
Related Issues (20)
- PHP Config: LayerCollector should reference layer by variable HOT 2
- PHP Config: Baseline improvements
- Irrelevant transient dependencies reported HOT 3
- Circular reference for layer collector as a standalone collector
- How to prevent depending on tests and vendor directories HOT 12
- Add the ability to disable rules through configuration
- Baseline not skipping multiple violations of same reference
- PHAR: Compiled phar cannot find services HOT 3
- Composer collector exception when package does not exist HOT 1
- deptrec help analyse throws: InvalidLayerDefinitionException
- [debug:layer] display token types
- PHAR: add "KevinGH\\Box\\Compactor\\Php" to reduce the size
- Update PHPUnit to version 10
- Update Psalm to version 5
- Add ".gitattributes" and exclude unnecessary files from packaged release
- Next Release: Reduce the distribution to just one method for the next release HOT 8
- Collector for excluding the layer in which it is specified.
- Ambiguous of @internal HOT 1
- Cache directory for Cache File not created automatically HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from deptrac.