Giter Club home page Giter Club logo

Comments (4)

patrickkusebauch avatar patrickkusebauch commented on May 26, 2024

This kind of begs the question, what should be the base path that this collector should look at in case a relative path to the file is provided?

from deptrac.

gennadigennadigennadi avatar gennadigennadigennadi commented on May 26, 2024

Did you @patrickkusebauch or @dbrumann discussed, what deptrac sees as its base path?

  • the users current dir?
  • the path of the deptrac executable?
  • the paht of the deptrac-config?

In the code I have seen Parameters for currentWorkingDirectory and projectDirectory and both get getcwd() assigned.

The documentations says:

* `%currentWorkingDirectory%` The path Deptrac runs in
* `%projectDirectory%` The path where the configuration is stored.

But what I see in the code is:

        if (false === ($currentWorkingDirectory = getcwd())) {
            throw CannotGetCurrentWorkingDirectoryException::cannotGetCWD();
        }

        ....
        $factory = new ServiceContainerBuilder($currentWorkingDirectory);
    public function build(): ContainerBuilder
    {
        $container = new ContainerBuilder();

        $container->setParameter('currentWorkingDirectory', $this->workingDirectory);

        self::registerCompilerPasses($container);
        self::loadServices($container, $this->cacheFile);

        $container->registerExtension(new DeptracExtension());

        $container->setParameter('projectDirectory', $this->workingDirectory);
        if (null !== $this->configFile) {
            self::loadConfiguration($container, $this->configFile);
        }

        $container->compile(true);

        return $container;
    }

I could work on this problem as soon as I understand the path situation. Btw it's also relevant for the #1078, I think.

from deptrac.

patrickkusebauch avatar patrickkusebauch commented on May 26, 2024

Nope, we didn't.

from deptrac.

gennadigennadigennadi avatar gennadigennadigennadi commented on May 26, 2024

This kind of begs the question, what should be the base path that this collector should look at in case a relative path to the file is provided?

I would say, relative to the config-file.

from deptrac.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.