Comments (7)
Hi, could you check the latest revision and update your comment ?
The code is now more complete
#ifndef __cplusplus
#if defined(HAVE_STDBOOL_H)
/*
The C language implementation does correctly provide the standard header
file "stdbool.h".
*/
#include <stdbool.h>
#else
/*
The C language implementation does not provide the standard header file
"stdbool.h" as required by ISO/IEC 9899:1999. Try to compensate for this
braindamage below.
*/
#if !defined(bool)
#define bool int
#endif
#if !defined(true)
#define true 1
#endif
#if !defined(false)
#define false 0
#endif
#endif
#endif /* __cplusplus */
Original comment by [email protected]
on 8 Apr 2010 at 6:21
- Changed state: Started
from openjpeg.
i dont think that makes any difference to my original report. openjpeg.h still
requires someone to either manually include stdbool.h first or manually define
HAVE_STDBOOL_H before including openjpeg.h. neither of these are generally
accepted
practices wrt library behavior and makes testing for header/library existence in
standard build systems (like autotools) painful.
Original comment by [email protected]
on 9 Apr 2010 at 2:07
from openjpeg.
Hi,
Could you suggest a patch to correct this issue ?
Original comment by [email protected]
on 26 Apr 2010 at 7:37
from openjpeg.
What are the platforms that don't have stdbool.h?
Original comment by [email protected]
on 15 Nov 2010 at 11:32
from openjpeg.
This patch fixes the issue when using cmake. I didn't do a version for
autotools, because Gentoo uses the cmake build system, but vapier's suggestion
should work fine.
Hope this helps.
Original comment by [email protected]
on 10 May 2011 at 5:54
Attachments:
from openjpeg.
Hi,
Thanks for the patch. Eventually, we have opted for a more "radical" solution:
define a new type opj_bool, and two constants OPJ_FALSE and OPJ_TRUE. See r778
for more details.
Comments welcome.
Cheers,
Antonin
Original comment by antonin
on 18 May 2011 at 11:07
from openjpeg.
Original comment by antonin
on 26 May 2011 at 8:53
- Changed state: Fixed
from openjpeg.
Related Issues (20)
- Heap-buffer-overflow in opj_dwt_decode
- Proposal to extend 'COM' comments
- Do not link with -ffast-math
- Inconsistent fixed point rounding
- opj_compress run twice gives different fiile sizes for same file HOT 3
- Might consider renaming this method:
- Potential double free on malloc failure in opj_j2k_copy_default_tcp_and_create_tcp() HOT 2
- incorrect encoding or decoding result HOT 3
- Undefined printf format specifier %ud used in code HOT 1
- Invalid write in opj_j2k_update_image_data HOT 3
- Double free in j2k_read_ppm_v3 parsing ((presumably invalid) image. HOT 1
- opj_setup_encoder always returns true HOT 3
- SIMD Acceleration for Forward DWT HOT 2
- Implement PCRD-OPT Rate Control
- opj_data/input/nonregression/issue226.j2k HOT 1
- Openjpeg3D lossy compression not working
- potential overflow in opj_j2k_get_tile_data() method
- Defect in Streaming API HOT 2
- Add buffer stream interface HOT 2
- Decode times almost double(!!) on Visual Studio 2013, 2015
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openjpeg.