Comments (10)
Maybe this has impact on the current milestone. If not change the label again.
from qabel-core.
@thechauffeur The criticalness depends on whether or not the milestone requires proper management of module settings.
@Gottox How much work has to be done in order to enable settings management for modules?
I think there are more important bits to do and settings could be held alternatively, too.
So therefore, I'd say not relevant for this milestone. @Gottox what do you mean?
from qabel-core.
I don't think this is a time critical task.
The idea behind the ModuleSettings is, that they are defined by their type. Take this for example: A module has its own implementation of a AbstractModuleSettings class (FooModuleSettings). There will be only one instance of this type.
What I hadn't in mind was that these classes are serialized to JSON. So yes, we need such a field.
Furthermore we need a custom deserializer for this class.
So things todo are:
- add a field to identify the type for deserialization
- add a deserializer to load those classes and instanciate them.
from qabel-core.
Good, I'll remove the time-critical label now.
from qabel-core.
We have to discuss again how to implement this and how to use this.
from qabel-core.
@cburkert with is ancient. Close this if not needed anymore.
from qabel-core.
I think this issue is still unresolved, because the type adapter for abstract module settings is still missing. @Gottox you started the todo list above. Am I right?
There is also a todo comment in the SyncSettingsTypeAdapter.
from qabel-core.
@cburkert you looked into this. Please make a PR and let @f-porter review it.
from qabel-core.
BUMP.
@cburkert what is the status of this issue? If you did something about this (e.g. a PR) it is not mentioned here.
from qabel-core.
Almost finished. I have to polish up the code, write same tests and that's it. Stay tuned.
from qabel-core.
Related Issues (20)
- Emojis in nick name or alias break the avatar
- FSCK for box volumes HOT 5
- define color space for contacts HOT 2
- Pin TLS certificate CA
- configurable test servers HOT 1
- Cross-client sync for contacts
- Cross-client sync for chat history
- qabel-cli
- qabel-cli project base
- qabel-cli box upload/download
- qabel-cli chat send and dump
- qabel-cli box ls
- Web Access
- cross client sync of drop messages HOT 1
- cross-client sync of contacts HOT 1
- qabel-cli noisebox encrypt|decrypt HOT 1
- Master is broken on GOCD-CI server HOT 1
- Cache downloaded metadata
- Transactions for Repositories HOT 2
- Mocking framework HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from qabel-core.