Detail handling of module settings about qabel-core HOT 10 CLOSED

Maybe this has impact on the current milestone. If not change the label again.

from qabel-core.

@thechauffeur The criticalness depends on whether or not the milestone requires proper management of module settings.

@Gottox How much work has to be done in order to enable settings management for modules?

I think there are more important bits to do and settings could be held alternatively, too.
So therefore, I'd say not relevant for this milestone. @Gottox what do you mean?

from qabel-core.

I don't think this is a time critical task.

The idea behind the ModuleSettings is, that they are defined by their type. Take this for example: A module has its own implementation of a AbstractModuleSettings class (FooModuleSettings). There will be only one instance of this type.

What I hadn't in mind was that these classes are serialized to JSON. So yes, we need such a field.

Furthermore we need a custom deserializer for this class.

So things todo are:

• add a field to identify the type for deserialization
• add a deserializer to load those classes and instanciate them.

from qabel-core.

Good, I'll remove the time-critical label now.

from qabel-core.

We have to discuss again how to implement this and how to use this.

from qabel-core.

@cburkert with is ancient. Close this if not needed anymore.

from qabel-core.

I think this issue is still unresolved, because the type adapter for abstract module settings is still missing. @Gottox you started the todo list above. Am I right?
There is also a todo comment in the SyncSettingsTypeAdapter.

from qabel-core.

@cburkert you looked into this. Please make a PR and let @f-porter review it.

from qabel-core.

BUMP.

@cburkert what is the status of this issue? If you did something about this (e.g. a PR) it is not mentioned here.

from qabel-core.

Almost finished. I have to polish up the code, write same tests and that's it. Stay tuned.

from qabel-core.