Giter Club home page Giter Club logo

Comments (2)

shivamshriwas avatar shivamshriwas commented on May 22, 2024

Black list env var uses regex for filtering out env variables which are not required or need to be restricted.

These env variables are used to start model worker and changing it to whitelist can easily break functionality as there are too many default env variable as well python virtual env variable which if missed to whitelist will affect funcionality.

Even if still wants to whitelist env var , user can write a regex accordingly.

eg : to blacklist env variables staring with Aws user can use regex ^(aws|AWS)[a-zA-Z0-9_]+$

A user may achive whitelist behaviour by providing a negate of regex

eg: user want to whitelist only env vars starting with aws user can use regex ^(?!aws|AWS)[a-zA-Z0-9_]+$

Considering the above analysis current code for blacklist env vars should not be changed.

from serve.

harshbafna avatar harshbafna commented on May 22, 2024

Closing this due to inactivity and the environment variable restriction can be easily controlled through REGEX. Please reopen if required.

from serve.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.