Comments (2)
Is this a generic bug or just specific to _allow_done_after_reset
?
Not sure it's really a bug in general, there are instances where one would like to have different attributes in the transformed env and in the env.
For some (eg _allow_done_after_reset
?) we can have fallbacks if we're confident that there is no reason for TransformedEnv to have a different behaviour. It's already the case for batch_size, device, run_type_checks and others.
For instance, I can imagine that if one is using the no-op transform she expects the behaviour of _allow_done_after_reset
to change.
from rl.
We can default to the attribute value in the original env and the specific transforms can change it.
I think it is counterintuitive that, if the transform does not need to change the property, the wrapper changes it.
Not sure if it is just specific to this
from rl.
Related Issues (20)
- [BUG] Shape Mismatch with default_info_dict_reader HOT 2
- [Feature Request] Simplify the example and tutorial codes HOT 4
- [Feature Request] Muzero and MCTS implementations HOT 1
- [BUG] Parallel envs override each others' num threads HOT 1
- [BUG] `check_env_specs` shouldn't set `torch.manual_seed` by default. HOT 3
- [BUG] Ray's actor construction is broken in docstring HOT 11
- [BUG] Problems with BatchedEnv on accelerated device with single envs on cpu HOT 29
- [BUG] Truncated key is on different devices with BatchedEnv on different device than single envs. HOT 2
- [Feature Request] partial steps in batches envs HOT 1
- [BUG] SliceSampler proposes indices outside storage content
- [Feature Request] PrioritizedSliceSampler
- [BUG]
- [Feature Request] Multi-dim RBs
- [Feature Request] Streamline preproc of datasets HOT 2
- [BUG] UserWarning: Failed to import torchrl C++ binaries HOT 4
- [Feature Request] Make `KLControllerBase` independent of the model HOT 1
- [BUG] Asked to report bug by a `UserWarning` HOT 1
- [Feature Request] Tutorial for custom env with complex shapes HOT 1
- [Feature Request] Why have mutually exclusive terminated and truncated? HOT 8
- [BUG] `FlattenObservation` transform with `OneHotDiscreteTensorSpec` HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rl.