Giter Club home page Giter Club logo

Comments (2)

vmoens avatar vmoens commented on June 26, 2024

Is this a generic bug or just specific to _allow_done_after_reset?

Not sure it's really a bug in general, there are instances where one would like to have different attributes in the transformed env and in the env.
For some (eg _allow_done_after_reset?) we can have fallbacks if we're confident that there is no reason for TransformedEnv to have a different behaviour. It's already the case for batch_size, device, run_type_checks and others.

For instance, I can imagine that if one is using the no-op transform she expects the behaviour of _allow_done_after_reset to change.

from rl.

matteobettini avatar matteobettini commented on June 26, 2024

We can default to the attribute value in the original env and the specific transforms can change it.

I think it is counterintuitive that, if the transform does not need to change the property, the wrapper changes it.

Not sure if it is just specific to this

from rl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.