Giter Club home page Giter Club logo

Comments (9)

albertbou92 avatar albertbou92 commented on September 23, 2024

You are right! Maybe a sign transform would be necessary.
Although, in practice, are there any Atari environments with rewards smaller than +1/-1

from rl.

skandermoalla avatar skandermoalla commented on September 23, 2024

Good point! I didn't think at all if in practice this would actually be different.

from rl.

vmoens avatar vmoens commented on September 23, 2024

We should have a SignReward transform then I guess.
(Another example of bad naming conventions in RL...)

from rl.

vmoens avatar vmoens commented on September 23, 2024

@skandermoalla @albertbou92 do you guys want to code a SignTransform transform for this? I can maybe take care of it today or tomorrow, if you're not working on it atm

from rl.

albertbou92 avatar albertbou92 commented on September 23, 2024

I am not working on it atm. I don't mind doing the PR on the side if you want to focus on other stuff. I will take longer than today/tomorrow though.

from rl.

skandermoalla avatar skandermoalla commented on September 23, 2024

Not working on it atm and unlikely to do so this week. Would be great if you took it. Thanks!

from rl.

albertbou92 avatar albertbou92 commented on September 23, 2024

Added a SignTransform in #1798

from rl.

vmoens avatar vmoens commented on September 23, 2024

We need to adapt the scripts now I think

from rl.

albertbou92 avatar albertbou92 commented on September 23, 2024

#1870

from rl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.