compilation error on windows about extension-cpp HOT 8 OPEN

Hi, thanks for reporting this issue. This is not enough information to help me debug your issue. Please fill out this template here: https://github.com/pytorch/pytorch/blob/master/.github/ISSUE_TEMPLATE.md and update your description so that I can better understand how to fix your problem.

from extension-cpp.

so this issue is solved?

from extension-cpp.

Sorry, I didn't see you had updated the issue. There was no response on my comment so I thought you had solved the issue.

from extension-cpp.

I will have to investigate this. I recall running into various issues with setup.py on windows. I believe pybind11 actually requires a custom CMake setup on Windows (see here) -- setuptools may not work out of the box.

from extension-cpp.

OK，thank you for your response， i will try pybind cmake first

from extension-cpp.

I tried pybind cmake example, it works for me, but i don't know how to incorporate pybind cmake to the pytorch cpp extension build system, could you please help me?

from extension-cpp.

Can you share your CMakeLists.txt? But all you'll really need is:

• Add the correct include paths from the torch/lib/include of you pytorch install (in site-packages): https://github.com/pytorch/pytorch/blob/master/torch/utils/cpp_extension.py#L240,
• Add the include paths for CUDA ($CUDA_HOME/include),
• Link in the correct ATen and CUDA libraries: -lATen and -lcudart.

Essentially everything that https://github.com/pytorch/pytorch/blob/master/torch/utils/cpp_extension.py#L213 does.

from extension-cpp.

I use the following CMakeLists.txt

cmake_minimum_required(VERSION 2.8.12)
project(lltm)
add_subdirectory(pybind11)
include_directories("C:\Program Files (x86)\Microsoft Visual Studio\Shared\Anaconda3_64\Lib\site-packages\torch\lib\include")
include_directories(ENV{CUDA_PATH_V9_1}\include)
link_directories("C:\Program Files (x86)\Microsoft Visual Studio\Shared\Anaconda3_64\Lib\site-packages\torch\lib")
pybind11_add_module(lltm src/lltm.cpp)
target_link_libraries(lltm PRIVATE ATen)

howerver, I still got the lnk 2001 error:

lltm.obj : error LNK2001: unresolved external symbole __imp_THPVariableClass
lltm.obj : error LNK2001: unresolved external symbole "struct _object * __cdecl THPVariable_Wrap(struct torch::autograd::Variable)" (?THPVariable_Wrap@@YAPEAU_object@@uvariab
le@autograd@torch@@@z)

from extension-cpp.