Giter Club home page Giter Club logo

Comments (7)

davidspek avatar davidspek commented on August 18, 2024 1

@kiukchung I'm very sorry but this seems to have been an error on my part. I was trying to build a docker image and the message made it seem like torchelastic had a dependency issue with torch. The problem was actually that torchelastic with the dependency torch>=1.8.0dev was conflicting with a package that does not yet support torch 1.8. Thank you for the quick response and again sorry for the incorrect issue.

from elastic.

davidspek avatar davidspek commented on August 18, 2024 1

@kiukchung Thanks for the info. The images I am working on are the ones that will ship with the upcoming Kubeflow release, and PyTorch and TensorFlow use a common base image I made so using the PyTorch docker image isn't an option. But it's good to know it is included for other use cases.

from elastic.

davidspek avatar davidspek commented on August 18, 2024

@kiukchung Should I open a PR to change https://github.com/pytorch/elastic/blob/master/requirements.txt to toch>=1.8.0? Is that the cause of the current incompatibility with torch 1.8.

from elastic.

kiukchung avatar kiukchung commented on August 18, 2024

@davidspek - thanks for reporting. Could you provide the details of the pip error?

from elastic.

kiukchung avatar kiukchung commented on August 18, 2024

FWIW the pytorch-1.8 docker images already have torchelastic installed.

from elastic.

kiukchung avatar kiukchung commented on August 18, 2024

ah gotcha, btw torchelastic is being upstreamed to pytorch (see pytorch/pytorch#50621), we are about 70% through with the code move (this is why our CI tests are broken at the moment). torchelastic will be natively available through the pytorch package starting torch-1.9.

from elastic.

davidspek avatar davidspek commented on August 18, 2024

Awesome, I think that move makes a lot of sense.

from elastic.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.