Comments (3)
ejguan
commented on August 18, 2024
1
Thanks to @pmeier , we have added pre-commit hook to run auto formatter. ufmt is also included to make everything sorted.
Closing this Issue.
from data.
pmeier
commented on August 18, 2024
We recently opted to use ufmt as code formatter. It combines black and usort. AFAIK, isort had some issues on FB architecture. cc @NicolasHug
The final vote is still out, but if we go for it, I can send a PR adopting it here too.
from data.
NicolasHug
commented on August 18, 2024
Yes, ufmt was specifically made to match fb's internal arc lint.
If we expect pytorch/data to be modified from withing fbcode from time to time, I think it's much safe to keep fbcode linting and github linting in sync
from data.
Related Issues (20)
- Iterating a data pipe, created with random split, ends in error as the code tries to iterate past the data pipe lenght
- `v2.1.2+cu118` and `v2.1.1+cu118` run into torchdata `ImportError: libssl.so.3: cannot open shared object file: No such file or directory`, that `v2.1.0+cu118` doesn't have an issue with HOT 1
- PyTorch 2.2: import torchdata fails on ubuntu-20.04 github runners HOT 3
- Dataloader is slow with iterdatapipes and shuffle that has large in-memory fields (because traverse_dps is slow) HOT 3
- DataLoader2 with multiprocess raise exception: Can not request next item while we are still waiting response for previous request HOT 1
- Move to removesuffix string method after python 3.8 support is dropped
- torchdata not compatible with torch 2.3.0 HOT 3
- [StatefulDataLoader] macOS tests are too slow
- MacOS state_dict tests in CI are failing during shutdown HOT 2
- StatefulDataLoader stores worker state twice if the IterableDataset is also an Iterator
- GDriveReaderDataPipe complains "using a sharing/viewing link instead of a download link"
- iter(dataset) is called twice for certain cases of state restore of IterableDataset HOT 3
- State_dict on dataset seems to be called more often than expected HOT 2
- Make DistributedSampler stateful HOT 4
- Enable Append Mode in SaverIterDataPipe HOT 1
- Returning tensor instead of dict for state_dict causes failure HOT 2
- Importing `torchdata.stateful_dataloader` hides `torch` RandomSampler and BatchSampler HOT 8
- best practice for `snapshot_every_n_steps` HOT 1
- what's the exact plan for torchdata now? HOT 1
- early stop worker got Exception Error HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from data.