'custom_lstms.py': name 'List' is not defined about benchmark HOT 9 CLOSED

Yes, we should close this issue because it is not relevant anymore.

from benchmark.

I confirm the bug

from benchmark.

Please follow the issue template and at least post a minimal example that would let us reproduce this error.

from benchmark.

The error is raised when I run rnns\fastrnns\custom_lstm.py (I renamed it 'lstm_test.py')
The problem is in the test of bidirectional lstm, the Traceback error is posted above.
Thank you for your help

from benchmark.

@FedericOldani

https://github.com/pytorch/pytorch/blob/44a607b90c9bba0cf268f833bae4715221346709/torch/jit/annotations.py#L33

Check this in the annotations.py of your pytorch version.
Probably this is missing .

from benchmark.

So how to fix this ? update to pytorch1.1 ?
I use pytorch1.0.1 and in annotations.py it has

_eval_env = {
    'torch': Module('torch', {'Tensor': torch.Tensor}),
    'Tensor': torch.Tensor,
    'typing': Module('typing', {'Tuple': Tuple}),
    'Tuple': Tuple,
}

from benchmark.

For fast fixing, I remove all the lines @jit.script_method. Let me know if you solve the problem.

from benchmark.

@FedericOldani But it seems that the custom lstm has no relation with jit . It also woks if class LSTMCell(nn.Module) without undering jit. And LSTMCell(nn.Module) runs faster than LSTMCell(jit.Module).

from benchmark.

I was looking at the issue from triage aspect, and I couldn't reproduce the error, and I see don't rnns\fastrnns\custom_lstm.py anymore. Perhaps, the issue is not relevant and now and we should close. Thanks! cc @xuzhao9

from benchmark.