Giter Club home page Giter Club logo

Comments (5)

methane avatar methane commented on May 27, 2024 2

I think comitter should decide news is required or not.
I don't ignore PRs only because red cross.

from blurb_it.

Mariatta avatar Mariatta commented on May 27, 2024 1

Many docs-related PRs don't require news file. If a contributor just created a blurb file with not meaningful info, it is more difficult to remove the file (from within GitHub UI), but removing a label is easy.

from blurb_it.

jdemeyer avatar jdemeyer commented on May 27, 2024

I think comitter should decide news is required or not.

The committer should decide but PR author should be able to propose. Just like the committer decides what gets merged but the PR author proposes the patch.

I don't ignore PRs only because red cross.

Maybe you don't, but at least @willingc said "In other projects that I maintain, I rarely look at a PR that does not have a green checkmark" (https://discuss.python.org/t/github-labels-and-pr-review-workflow/237)

from blurb_it.

Mariatta avatar Mariatta commented on May 27, 2024

I personally think it is ok for non-committer to apply the skip news label to pass the CI.
If a core dev disagrees, it is quite easy to remove the label.

blurb-it (GitHub App) might not have the permission to add label. We might need to do this using bedevere's OAuth token.

from blurb_it.

jdemeyer avatar jdemeyer commented on May 27, 2024

This might be easier with bedevere: python/bedevere#175

from blurb_it.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.