Decide what to do with additionalProperties with patternProperties present about jsonschema HOT 14 CLOSED

Your schema is wrong, it's properties, not property, which is why additionalProperties is still validating foo there.

from jsonschema.

Yeah, you're right.

But at first time I wanted to post other example (with patternProperties). Then I changed it to properties to simplify example (and made typo as well :) )

So, here is the thing:

    instance = {"foo": 123}
    schema = {
        "type": "object",
        "patternProperties": {
            "^f.o$": {
                "type": "integer",
            },
        },
        "additionalProperties": {
            "type": "string"
        }
    }
    validate(instance, schema)

raises error as above.

I'm not 100% sure whether additionalProperties should be aware about patternProperties.
Draft does not clarify things as well.

from jsonschema.

Ah, OK. I'll have to take a look later, but that sounds reasonable.

from jsonschema.

Had the same issue. Below is my diff - hope this helps

410,417c410
<         #extras = set(instance) - set(schema.get("properties", {})) - set(schema.get("patternProperties", {}))
<         extras = []
<         for k in set(instance) - set(schema.get("properties", {})): 
<             for regex in set(schema.get("patternProperties", {})):
<                 if not re.match(regex, k):
<                     extras.append(k)
<         extras = set(extras)
< 
---
>         extras = set(instance) - set(schema.get("properties", {}))

from jsonschema.

Cool. Any chance you'd like to write the test :)?

from jsonschema.

I can, but what exactly do you need me to do? do you want a sample json-schema.

from jsonschema.

Hi Julian,
I'd like to wrap hobbez1's solution with tests and push it back.
But on my machine, tox failed to run 16 tests.

$ python
Python 2.6.1 (r261:67515, Jun 24 2010, 21:47:49)
[GCC 4.2.1 (Apple Inc. build 5646)] on darwin

Do I need python2.7 (3.*) for this?

from jsonschema.

Well, you'd need a copy of each of python2.6, python2.7, python3.2, and pypy to run all of tox, but I'm perfectly OK with just running it against one of those (whichever you have, 2.6 should be fine) locally and then I can run it through tox before I pull it.

You certainly shouldn't be seeing failures though, can you pastebin those?

from jsonschema.

here it is: http://pastebin.com/gUZJer6m

from jsonschema.

Interesting. I have 2.6.7 locally, which is what I use to test compatibility with 2.6, but I guess I'll have to take a look at that on 2.6.1. If you have access to a later version it should work, if not gimme a bit I'll take a look at what's going wrong. Thanks for taking a look at this.

from jsonschema.

Ah I remember, this is a unicode thing. Early python 2.6's didn't allow unicode keyword arguments. This should only be an issue in the tests. I'd ignore them, it looks like you have a version of python 3.2 there, so just test against that by doing tox -e py32 and you should be good. Lemme know how that goes. Thanks again.

from jsonschema.

Any luck? Not rushing you, just checking if you're working on this. If not I can merge it myself with the small test case.

from jsonschema.

No luck :)
I didn't have a chance to start working on it. I was planning to prepare pull request on weekends.

from jsonschema.

FYI, finally I've started to prepare pull request :)

from jsonschema.