Giter Club home page Giter Club logo

Comments (3)

adam-grant-hendry avatar adam-grant-hendry commented on June 6, 2024 1

Thank you @sirosen ! You are an excellent maintainer. Thank you for responding so quickly. I can confirm on my end that this solves my problem. Thank you!

from check-jsonschema.

sirosen avatar sirosen commented on June 6, 2024

Thanks for the report, I'll take a look at this today.

I'm pretty sure that the issue is on this line, that it calls open without specifying an encoding:

I think I'll change it to use utf-8, since that's what 99.9% of users will expect. That will prevent the use of a locale/default encoding. If someone has an alternate encoding and it causes issues, I can add options to control this or look at chardet and other tools to see what's appropriate.

from check-jsonschema.

sirosen avatar sirosen commented on June 6, 2024

I've just released a fix for this in v0.14.3 which changes the above line to open(fn, encoding="utf-8").
This should fix the issue, but please let me know if you see any trouble with it!

I also added a new test for this, which I confirmed was failing on GitHub Actions windows builds without the fix.

from check-jsonschema.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.