Comments (7)
Lukasa
commented on July 26, 2024
Actually, I'm not convinced about the HPACK case. For the encoder it's an obvious win, but for the decoder it's a little painful: we do some indexing into the header table, and that'll slow down with a deque.
from hyper.
Lukasa
commented on July 26, 2024
Wait, we've got a giant number of integration tests for the HPACK stuff. Let's just try the replacement, and see if they run faster!
from hyper.
Lukasa
commented on July 26, 2024
Alright, here's the result running against the current master with a warm cache:
============================= test session starts ==============================
platform darwin -- Python 3.3.3 -- pytest-2.5.1
collected 434 items
test/test_hpack_integration.py ..................................................................................................................................................................................................................................................................................................................................................................................................................................................
========================= 434 passed in 23.64 seconds ==========================
from hyper.
Lukasa
commented on July 26, 2024
Just changing the Encoder to use deques is unlikely to have a huge effect on the test run-time, as it only executes very infrequently, but it's also the bit that's most likely to do well. With a warm cache, we get a very small win:
============================= test session starts ==============================
platform darwin -- Python 3.3.3 -- pytest-2.5.1
collected 434 items
test/test_hpack_integration.py ..................................................................................................................................................................................................................................................................................................................................................................................................................................................
========================= 434 passed in 23.56 seconds ==========================
from hyper.
Lukasa
commented on July 26, 2024
Yeah, no great win here, sadly.
============================= test session starts ==============================
platform darwin -- Python 3.3.3 -- pytest-2.5.1
collected 434 items
test/test_hpack_integration.py ..................................................................................................................................................................................................................................................................................................................................................................................................................................................
========================= 434 passed in 23.53 seconds ==========================
from hyper.
Lukasa
commented on July 26, 2024
We don't make it worse, though, and they're really the right structure for the job, so I'll use them.
from hyper.
Lukasa
commented on July 26, 2024
Resolved in d804f21 and 93bb280.
from hyper.
Related Issues (20)
- Ping does not work correctly HOT 3
- Edit on github link on RTD broken.
- Transfer of maintenance HOT 3
- HTTP20Adapter sends extra headers ?? HOT 20
- How to control ssl context in a HTTP20Adapter HOT 1
- hyper.contrib.HTTP20Adapter with requests.session not working on python 2.7
- Upgrade from HTTP/1.1. to HTTP2 not working HOT 2
- Could you please make MAX_CHUNK configurable? HOT 1
- Upgrade to the latest h2 HOT 2
- How resolve DNS to a specific IP?
- HTTP11Connection does not use http/1.1 protocol HOT 1
- hyper hangs while POSTing to Apple APNS servers HOT 2
- Forcing Cleartext HTTP2 Without Upgrade Mechanism HOT 3
- How can I add query parameters when using class HTTP20Connection?
- Python deprecation warnings: collections, imp, logging.warn
- basestring erroneously ignores unicode in Python2.7
- Client certificates?
- Retain connection in HTTP/2 using hyper to avoid authentication for every request
- HTTP20Connection.request has no mechanism to send duplicate headers HOT 3
- The orders of sending packages in Debug mode and Run mode are different.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hyper.