Comments (4)
ChrisLovering
commented on August 10, 2024
We listen to the former of the two events here https://github.com/python-discord/metricity/blob/main/metricity/exts/event_listeners/guild_listeners.py#L56-L62
Have you seen an example a thread's archive state not being updated? we might need to start listening to the second if so.
I didn't bother listening to the second event originally as my understanding was an active thread should always be in the bot's cache, so archiving a thread should mean that it always triggers the first event.
from metricity.
jchristgit
commented on August 10, 2024
Thanks for the quick reply!
We listen to the former of the two events here https://github.com/python-discord/metricity/blob/main/metricity/exts/event_listeners/guild_listeners.py#L56-L62
I missed this, thank you for linking to it.
Have you seen an example a thread's archive state not being updated? we might need to start listening to the second if so.
Yes. I've done some data exploration on lovelace in metricity earlier
today, and found this:
metricity=# SELECT COUNT(*) FROM threads WHERE NOT archived; -- pre metricity restart
count
-------
1389
(1 row)
metricity=# SELECT COUNT(*) FROM threads WHERE NOT archived; -- post metricity restart
count
-------
88
(1 row)
I'm not sure if it's necessarily the lacking raw event handler, although
the sync function seems to be working correctly based on the result
after successful startup.
I didn't bother listening to the second event originally as my understanding was an active thread should always be in the bot's cache, so archiving a thread should mean that it always triggers the first event.
Hm, it seems intuitive to me as well, but maybe that is not how it
works.
By the way, reading the code as I understand it currently we will
synchronize each of the current threads on the guild on any thread
update. Maybe we could make it more granular. Although since this is
just a few dozen it shouldn't matter too much, this isn't the user cache
after all.
from metricity.
ChrisLovering
commented on August 10, 2024
Just spotted why, #156 should fix this
from metricity.
ChrisLovering
commented on August 10, 2024
currently we will synchronize each of the current threads on the guild on any thread update
Yeah just spotted this too, seems quite heavy handed, but as you say it's still a small number of queries as far as postres is concerned
from metricity.
Related Issues (10)
- Threads Support HOT 36
- Getting "RuntimeError: Task got Future <Future pending> attached to a different loop" on Windows HOT 4
- Vulnerabilities fix Request HOT 1
- Update message on message_edit HOT 2
- Ignore AutoMod Messages HOT 1
- Deprecation warning about uninstalled scripts on startup
- Users table has all users set to in_guild=False on user upsert HOT 9
- Messages backfill
- UniqueViolationError raised when inserting user
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from metricity.