Giter Club home page Giter Club logo

Comments (5)

nicoddemus avatar nicoddemus commented on September 7, 2024

Hmm, the problem is not the hookwrapper per-se, I think the problem is that currently processEvents() is being called after all fixtures are torn down (after the yield statement):

@pytest.mark.hookwrapper
def pytest_runtest_teardown(item):
    """
    Hook called after each test tear down, to process any pending events and
    avoiding leaking events to the next test.
    """
    yield
    app = QApplication.instance()
    if app is not None:
        if _exception_capture_disabled(item):
            app.processEvents()
        else:
            with capture_exceptions() as exceptions:
                app.processEvents()
            if exceptions:
                pytest.fail('TEARDOWN ERROR: ' + format_captured_exceptions(exceptions))

Just moving the yield statement would make the code run before all other fixture are tear down, which I think makes sense:

@pytest.mark.hookwrapper
def pytest_runtest_teardown(item):
    """
    Hook called after each test tear down, to process any pending events and
    avoiding leaking events to the next test.
    """
    app = QApplication.instance()
    if app is not None:
        if _exception_capture_disabled(item):
            app.processEvents()
        else:
            with capture_exceptions() as exceptions:
                app.processEvents()
            if exceptions:
                pytest.fail('TEARDOWN ERROR: ' + format_captured_exceptions(exceptions))
    yield

I will think about this a little more, but meanwhile feel free to add any comments or insights! 😄

from pytest-qt.

The-Compiler avatar The-Compiler commented on September 7, 2024

That seems to solve my issue, and all other tests still run fine for me.

I don't know what other implication that change would have, but I agree it sounds like it makes sense.

from pytest-qt.

nicoddemus avatar nicoddemus commented on September 7, 2024

I think actually we should process events both before and after the other tear down hooks, actually. Something like:

def _process_events(item):
    app = QApplication.instance()
    if app is not None:
        if _exception_capture_disabled(item):
            app.processEvents()
        else:
            with capture_exceptions() as exceptions:
                app.processEvents()
            if exceptions:
                pytest.fail('TEARDOWN ERROR: ' + format_captured_exceptions(exceptions))

@pytest.mark.hookwrapper
def pytest_runtest_teardown(item):
    """
    Hook called after each test tear down, to process any pending events and
    avoiding leaking events to the next test.
    """
    _process_events(item)
    yield
    _process_events(item)

This will allow queued events to be processed in a more predicable manner. What do you think?

from pytest-qt.

The-Compiler avatar The-Compiler commented on September 7, 2024

Could any new events even arrive during the teardown? But yeah - why not!

from pytest-qt.

nicoddemus avatar nicoddemus commented on September 7, 2024

Actually any call to app.processEvents() may trigger any arbitrary code, which in turn might post other events, and so on... this is specially problematic in X-Window because the events are asynchronous, so a processEvents() may end up not processing any events at all. 😟

Calling processEvents() before and after other fixtures is only a best-effort to getting all events processed.

from pytest-qt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.