IDs instead of [home, away, shirt_number] about kloppy HOT 4 CLOSED

Good one. I would like to make this configurable. When combining data from different providers it easier to use shirt numbers.

For what use case would you like the provider ids?

OR implement #3 and add a little helper / layer to go from shirt number to provider id. Although in some cases - like statsbomb - it requirements metadata (Lineup) to load the events, even when you don’t need the shirt numbers. That would be an argument to go for the provider ids by default and have a mapper to go to shirt numbers.

I think I’d prefer the last one. Would that work for you?

from kloppy.

By last one you mean "go for the provider ids by default and have a mapper to go to shirt numbers"? I'd agree with that. The game model on #3 could have field to specify which provider are the tracking and event from and that can be used in the mapper to go from ids to shirt number.

from kloppy.

Brainfart here for the internals: introduce a PlayerIdentifier type which holds IdentifierType (Jersey, Provider[Statsbomb], Provider[Metrica], etc) and the value.

and use player_id instead of jersey_number everywhere.

The PlayerIdentifier eq method should check type and raise exception when types don't match. This will prevent mistakes when trying to match different types of identifiers

from kloppy.

Fixed in #34

from kloppy.