Comments (8)
There are two things to this.
- We should make sure that the underlying metrics are initialized and set to
0
. Here is an example of this recently done to Prometheus itself: prometheus/prometheus#12472 - When alerting is disabled via the config spec we shall also exclude the SLOMetricAbsent alert. That's something I wanted to fix for a while...
Would that work for you too?
from pyrra.
We should make sure that the underlying metrics are initialized and set to 0. Here is an example of this recently done to Prometheus itself: prometheus/prometheus#12472
I thought the exact same thing: as long as the metrics are properly initialized it should be fine, as this is my preferred solution. But this is not always possible for two reasons:
- The amount of labelmatchers combinations that an SLO could contain.
- Metrics might come out of 3rd party libraries that are not initializing them and don't allow me to do it in my code.
from pyrra.
When alerting is disabled via the config spec we shall also exclude the SLOMetricAbsent alert.
Yes please that would fix it for us
from pyrra.
Related Issues (20)
- Improve Grafana dashboard HOT 1
- Running `make test` on main causes modified files HOT 1
- Specify labels for alerts HOT 1
- Pyrra - Sloth integration HOT 5
- Override SLO names HOT 2
- feat add Grafana explorer integration with pyrra UI HOT 8
- configurable logger HOT 1
- Populate the exhaustion time in the Alerts HOT 5
- [feature] SLOs / Rules validation HOT 1
- SLO does not pick up errors HOT 10
- Add basic auth support to the filesystem argument HOT 2
- Pyrra Fails to create Recording rules (msg="skipping prometheusrule" error="Invalid rule" ) HOT 1
- unknown field "latencyNative" in dev.pyrra.v1alpha1.ServiceLevelObjective.spec.indicator HOT 4
- Label changes to the `prometheus-http.yaml` file results in persistent versioned -generic rules HOT 1
- Add option to configure leaderElection HOT 3
- ratio with different metrics HOT 2
- multiple prometheus HOT 4
- no graphs in UI HOT 10
- local dev issue HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pyrra.