Giter Club home page Giter Club logo

Comments (8)

metalmatze avatar metalmatze commented on September 22, 2024

There are two things to this.

  1. We should make sure that the underlying metrics are initialized and set to 0. Here is an example of this recently done to Prometheus itself: prometheus/prometheus#12472
  2. When alerting is disabled via the config spec we shall also exclude the SLOMetricAbsent alert. That's something I wanted to fix for a while...

Would that work for you too?

from pyrra.

douglascamata avatar douglascamata commented on September 22, 2024

We should make sure that the underlying metrics are initialized and set to 0. Here is an example of this recently done to Prometheus itself: prometheus/prometheus#12472

I thought the exact same thing: as long as the metrics are properly initialized it should be fine, as this is my preferred solution. But this is not always possible for two reasons:

  • The amount of labelmatchers combinations that an SLO could contain.
  • Metrics might come out of 3rd party libraries that are not initializing them and don't allow me to do it in my code.

from pyrra.

taivo123 avatar taivo123 commented on September 22, 2024

When alerting is disabled via the config spec we shall also exclude the SLOMetricAbsent alert.

Yes please that would fix it for us

from pyrra.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.