Question about runoff conversion about atlite HOT 3 OPEN

You are right in both points that the unit conversion is inconsistent.

There was quite some iteration in the used datasets and projections in the beginning. When this was conceived it used a different runoff dataset which reported runoff in kg / m^2 / day which is about equivalent to mm / day and had shapes with areas that were given in km^2 so that you had to do:

mm / day * km^2 = 1 / 1000 * m / 24 / h * 1000^2 m^2 = 1000 / 24 * m / h

But none of this is valid anymore with the current era5 dataset and the cea projection, which uses metres directly.

But it also does not matter too much, since this function is mostly intended to generate a profile rather than a full inflow estimation for each power plant. ie. the output of this function should be rescaled according to historical output at measurement points in the river or historical annual/monthly generation of plants; so that whatever global factor is put in, will normalize out anyway.

You're invited to submit a quick PR to fix it here now.

from atlite.

Thanks for the fast and clear response.

Sorry, but I am rather new to GitHub, so I don't know how PR work. But if I understand correctly, you would just need to remove the (1000.0 / 24.0 ) term from the code.

from atlite.

Indeed

from atlite.