Comments (11)
I did not want to sound negative or hit on That "someone" is @dhoomakethu but I think he never got time to make test cases...please do not take this negative, we all have different priorities and
@dhoomakethu I am not I understand what you mean "happening both personally and ....", I hope you are not having a hard time !
This mad Dane (others just write "Viking", that explains it all), have a clear objective, which is to make pymodbus more robust. I really do my best to document all external changes in API_CHANGES, but like @alexrudd2 I depend heavily on CI to find places where a change have unwanted side effects, so missing tests means no red flags.
My short time plan is to expand our tests heavily (transport now have 100% coverage), simply because I too get tired of seeing regression bugs. Most of my other changes are actually down in the framer and transport.
This Viking is not alone in changing everything, we have had a constant flow of new developers making small changes, I take this as a healthy sign for the project. Lately there have been a lot of focus on type checking, and I have slowly been turned, so now all my new code are typed (big thanks to @alexrudd2 for heading this effort).
from pymodbus.
Looks like a bug, please let me investigate.
from pymodbus.
and I just read the last part....yes we are moving away from .params as fast as can, and there are probably a small number that have changed recently.
Thanks for helping out on this.
from pymodbus.
There are still not tests for REPL, and I don't know enough to write them. However, the linked PR "teaches" mypy
and friends about the base classes, so it can check the REPL more strictly.
from pymodbus.
Yeah "someone" promised to make quite a while ago, but it seems he has dropped completely out.
It is on my list, but behind a number of more urgent matters.
from pymodbus.
Who is that someone
😎???. I am sorry I am unable to keep up with the changes happening both personally and with this project. The best thing would be to move REPL out as a separate repo (I believe I have this proposed in the past as well) and keep only the core library as part of pymodbus.
from pymodbus.
Yes it has been proposed by the same person.
I think I will do it for v3.7.0, I agree it is a hazzle, mostly because the code have not been updated for a long time and thus depends on the old architecture.
@dhoomakethu heads up, in a couple of months REPL will be in each own repo....we might reintegrate it at a later date, when the simulator is finished, because it is a real nice feature to have.
from pymodbus.
I have a version ready with some changes, I will push it in sometime for initial discussion.
from pymodbus.
Yes it has been proposed by the same person.
whoosh! 😆
Who is that
someone
😎???. I am sorry I am unable to keep up with the changes happening both personally and with this project.
Haha, I also find it difficult to keep up with the mad Dane. It's one of the reasons I focus on automatic tools - to let the computer do the work.
Thanks to you both, of course. I used 2.5.3
very heavily, and 3.x
now also.
from pymodbus.
@janiversen I understand and no offense taken. Thanks for the concern. I know I have in the past talked about many things and I am not at all contributing. I will start contributing back on certain parts (hopefully) starting with repl.
from pymodbus.
Looking forward to that....you are the "old" guy in this project, with a lot more experience than I.
from pymodbus.
Related Issues (20)
- Use AbstractBaseClass when possible HOT 3
- StartAsyncTcpServer freezing HOT 10
- Client Connect Error: Target Machine Refused It HOT 9
- Reactive server no longer available with core pymodbus HOT 4
- ModbusException 0x07 is missing in pdu.py HOT 1
- pypi do not like repl. HOT 6
- RTU framer --> message HOT 2
- Clean repl from examples etc. HOT 1
- Read data with RTS HOT 6
- Message_Parser example not working on latest pymodbus release HOT 1
- Remove compare old/new encode in framer buildPacket. HOT 1
- Sporadic response decoding failures HOT 5
- Exception on read when no connection (self.transport is None). HOT 6
- Runtime Error when init AsyncModbusTcpClient outside of an running event loop HOT 2
- attached to a different loop HOT 1
- Pymodbus StartAsyncSerialServer serves only 1 result from datastore even when many are requested HOT 1
- Missing TLS certificate validation HOT 7
- `ModbusSerialClient` does not handle `termios.error` on `connect` HOT 2
- Activate use of message.decode for framer ASCII, SOCKET, TLS HOT 1
- client_server_sync_test have become very slow on 3.12 for no reason ?? HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pymodbus.