DNS resolution through SOCKS5 proxy about pyload HOT 6 CLOSED

@clst Wow, you get the most ancient issue bringer award 🌷

from pyload.

It works without modification, when you enter your proxy address with protocol prefix according to libcurl documentation:

Since 7.21.7, the proxy string may be specified with a protocol:// prefix to specify alternative proxy protocols.
Use socks4://, socks4a://, socks5:// or socks5h:// (the last one to enable socks5 and asking the proxy to do the resolving, also known as CURLPROXY_SOCKS5_HOSTNAME type) to request the specific SOCKS version to be used.
No protocol specified, http:// and all others will be treated as HTTP proxies.

I probably add a config option to make it more explicit later.

from pyload.

Ok, in this case a little info about this would be great ;-). I guess I've never seen a proxy hostname with a protocol prefix before.

This also makes the proxy type option obsolete.

from pyload.

This ticket has been automatically marked as inactive because 90 days have passed since the last comment.
It will be closed in 7 days if no further activity occurs.
If this issue still requires attention, please leave a comment.

from pyload.

This ticket has been automatically closed.
This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable.
Feel free to open a new issue if you deem it appropriate. Don't forget to reference this to the new one.
Thanks for your contributions.

from pyload.

I just ran into this.
It's an easy fix. Just change module\network\HTTPRequest.py

127:                 self.c.setopt(pycurl.PROXYTYPE, pycurl.PROXYTYPE_SOCKS5)

to

127:                 self.c.setopt(pycurl.PROXYTYPE, pycurl.PROXYTYPE_SOCKS5_HOSTNAME)

from pyload.