Giter Club home page Giter Club logo

Comments (5)

bitprophet avatar bitprophet commented on July 19, 2024

Seems the fork-of-a-fork on Github has its own changes I don't want to bother with (esp given pexpect-u itself works fine for me right now) so I'm going to just import from hg into git, slap it up on my own Github for shits n giggles, sixify and vendorize.

from invoke.

bitprophet avatar bitprophet commented on July 19, 2024

Ran this pexpect fork's test suite and about 5-6 seemingly minor things fail, things which don't seem like they're relative to my setup (e.g. the output of 'cat' and such). I.e. I'm wondering if they fail for the guy who forked it to begin with.

When I use this version in Invoke's test suite everything checks out at our level, so I think it's "good enough". Forging ahead.

from invoke.

bitprophet avatar bitprophet commented on July 19, 2024

Realizing that the reorg done by the earlier fork probably doesn't impact us, pexpect/__init__.py doesn't import anything else but stdlib. So I'll probably just be able to vendorize that one file as I was doing before. Ho hum.

Have a bunch of stuff already cleaned up, main issue is (as usual) bytes vs unicode, since pexpect (or the fork) is trying to handle some of that already which actually just complicates things.

from invoke.

bitprophet avatar bitprophet commented on July 19, 2024

Spoke too soon? Only had to remove all unicode checks/casts with six.string_type (after making sure that was the appropriate approach in each spot) and the Invoke suite is passing again.

Vendored the one file as above, seems to work OK.

from invoke.

bitprophet avatar bitprophet commented on July 19, 2024

Travis passes too, we're done

from invoke.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.