Giter Club home page Giter Club logo

Comments (7)

bwoodsend avatar bwoodsend commented on June 3, 2024 1

That does look like a better idea. I'll chime in there.

from pyinstaller-hooks-contrib.

bwoodsend avatar bwoodsend commented on June 3, 2024 1

Nothing's changed. Just --hiddenimport=vtkmodules.xxx the offending submodule every time you get the No module named vtkmodules.xxx message.

from pyinstaller-hooks-contrib.

bwoodsend avatar bwoodsend commented on June 3, 2024

I've always preferred to just --hiddenimport VTK's submodules in as needed. They're not particularly hard to find and it's far easier to find and add missing modules than it is to find and remove redundantly bundled modules. If someone's really determined enough to go through every submodule and identify exactly which other submodules each one loads then write a hook for each one then that would be good but it'll be misery incarnate. (Possibly PyInstaller.utils.hooks.get_pyextension_imports() could do it programatically albeit slowly?) But failing that, I really don't want to see a brute force collect_submodules("vtkmodules") approach for VTK because it'll dump ~200MB of potentially unused DLLs into every application.

Note that the hook-vtkpython.py is not for vtk but a separate Python port of VTK. We don't have a hook for the official VTK port.

from pyinstaller-hooks-contrib.

Jmennius avatar Jmennius commented on June 3, 2024

I've always preferred to just --hiddenimport VTK's submodules in as needed. They're not particularly hard to find and it's far easier to find and add missing modules than it is to find and remove redundantly bundled modules. If someone's really determined enough to go through every submodule and identify exactly which other submodules each one loads then write a hook for each one then that would be good but it'll be misery incarnate. (Possibly PyInstaller.utils.hooks.get_pyextension_imports() could do it programatically albeit slowly?) But failing that, I really don't want to see a brute force collect_submodules("vtkmodules") approach for VTK because it'll dump ~200MB of potentially unused DLLs into every application.

Note that the hook-vtkpython.py is not for vtk but a separate Python port of VTK. We don't have a hook for the official VTK port.

Thanks for the info!
I did not realize vtkpython is NOT from upstream VTK (I thought it was an earlier version).
Sadly get_pyextension_imports is not in documentation, but it doesn't seem to be clean solution either.

Regarding finding a nice solution - I have idea and opened an issue to discuss it with VTK folks.

from pyinstaller-hooks-contrib.

Jaime02 avatar Jaime02 commented on June 3, 2024

Any advances fixing this? Do I still need to use hidden imports?

from pyinstaller-hooks-contrib.

Jaime02 avatar Jaime02 commented on June 3, 2024

@bwoodsend but why not update the hooks?

from pyinstaller-hooks-contrib.

bwoodsend avatar bwoodsend commented on June 3, 2024

For the reasons outlined here and here.

from pyinstaller-hooks-contrib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.