Giter Club home page Giter Club logo

Comments (8)

arsenovic avatar arsenovic commented on May 19, 2024 1

yeah i hear ya, no prob

from clifford.

arsenovic avatar arsenovic commented on May 19, 2024

good point. seems to me that all you need to know is the signature to ensure the GA is the same, so we should be able to do self.layout.sig == other.layout.sig,
see any problems with this?

from clifford.

hugohadfield avatar hugohadfield commented on May 19, 2024

Sure, so the overwritten eq and ne operators in Layout should become:

def __eq__(self, other):
  return np.all(self.sig == other.sig)

def __ne__(self, other):
  return not self.__eq__(other)

from clifford.

arsenovic avatar arsenovic commented on May 19, 2024

yeah that makes sense to me.

from clifford.

arsenovic avatar arsenovic commented on May 19, 2024

do you want to submit a PR? or i can do it,

from clifford.

hugohadfield avatar hugohadfield commented on May 19, 2024

Yeah I was just looking at that! Probably easiest if you do it as I have messed up my local copy of the repo quite a lot...

from clifford.

arsenovic avatar arsenovic commented on May 19, 2024

let me know if this works for you ,
arsenovic@deb9648

from clifford.

hugohadfield avatar hugohadfield commented on May 19, 2024

Perfect, thanks :)

from clifford.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.