Comments (5)
@asp437 It has been done. You can install python-isal with pip install git+https://github.com/pycompression/python-isal
. This will install the latest and greatest including GIL escaping. Make sure you have the requirements for the ISA-L build instructions installed: https://github.com/intel/isa-l#building-isa-l. Otherwise it won't compile.
from python-isal.
@asp437 doing so makes working in a single-thread slower, but I agree that it is worth the overhead. It will also make it more comparable to the CPython implementation. I will add this to the todo list.
Have you consider releasing lock before executing I-SAL library functions that works with internal state (like isal_deflate)? I didn't fully checked all the details of I-SAL library and may miss some potential problems.
For compress and decompress it works fine. for the compressobj and decompressobj methods I believe the whole object is locked first in CPython to prevent the same state manipulated at the same time. So there shouldn't be any problems.
from python-isal.
Sounds good.
I can try to prepare a PR if you want to. I don't have experience writing C extensions for Python yet. But I can try to prepare the PR since I have knowledge of both Python and C. Probably I'll need some help to polish it in later stages from your side.
from python-isal.
No need. It is just a simple copy-paste operation from the zlibmodule.c in CPython. I prefer to do this work myself as I am quite picky about where exactly everything is copied. Trying to do this copy-paste through an external PR is not very efficient.
I am very busy currently so I cannot do it right away. Also the following issue needs to be resolved #133 before I can make a release. If you know anybody who could help me with that it would be much appreciated. In that case I can also give a bit more priority to this.
from python-isal.
Thank you, it was quite fast!
Will test it for my use cases in a few days.
from python-isal.
Related Issues (20)
- Release 1.3.0
- Release 1.4.0
- Release 1.4.1
- Release 1.5.0
- Memory leak in v1.4.0 and newer HOT 4
- Release 1.5.1
- Automatically test for memory leaks using libasan HOT 1
- igzip_threaded.open does not close opened file on error HOT 5
- Release 1.5.2
- igzip_threaded cannot append HOT 4
- Release 1.5.3
- _PyBytes_Join will be removed in 3.13
- IGzipFile should not crash on wrong compression level when opened for reading. HOT 5
- Release 1.6.0
- Release 1.6.1
- Error building wheels for isal HOT 19
- need for submodules is not explained in README HOT 5
- requirement for nasm is not documented in README HOT 2
- READ and WRITE should be inherited from the gzip module.
- Release 1.7.0 HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from python-isal.