Giter Club home page Giter Club logo

Comments (5)

mriehl avatar mriehl commented on May 18, 2024

What is the benefit of frosted, in particular versus flake8?
After a first look, it doesn't even catch "missing whitespace around operator".

From the project page (github) it seems better maintained, as there are no open issues but a lot of closed ones, but I am unsure about the current feedback from linting.

Please note that I am not trying to avoid doing this - by all means, we should provide as many plugins and alternatives as we possibly can - I simply want to do some grooming and wondering if writing this plugin yields more value than, say, generating a description from the markdown.

from pybuilder.

aelgru avatar aelgru commented on May 18, 2024

Well, my thought was that this works like many other cli tools and it would be nice to have something like a base class for this to make it easy to write plugins.

from pybuilder.

mriehl avatar mriehl commented on May 18, 2024

It's already easy with execute_tool_on_source_files, most of the necessary work is dealing with all the options from the program and turning them into properties to expose them to the user.

Maybe you could suggest how you would want to write the frosted plugin (maybe pass a dict with mapping from properties to command line options)?

from pybuilder.

aelgru avatar aelgru commented on May 18, 2024

Yes, or maybe a command-line-builder would be nice. Something like this would reduce the boilerplate in plugins like flake8.

from pybuilder.

mriehl avatar mriehl commented on May 18, 2024

For the command-line builder I have something like this right now :

    command = ExternalCommandWrapper('flake8', project)
    command.has_argument('--ignore={0}').formatted_with_property('flake8_ignore').only_if_property_is_truthy('flake8_ignore')
    command.has_argument('--max-line-length={0}').formatted_with_property('flake8_max_line_length')
    command.has_argument('--exclude={0}').formatted_with_property('flake8_exclude_patterns').only_if_property_is_truthy('flake8_exclude_patterns')

What do you think?

from pybuilder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.