Giter Club home page Giter Club logo

Comments (3)

dean0x7d avatar dean0x7d commented on August 31, 2024 1

The projects should be in sync now with the bulk of the changes in #5 and pybind/python_example#14.
I don't expect any huge changes in the future, so the sync should be easy to maintain.

from cmake_example.

dean0x7d avatar dean0x7d commented on August 31, 2024

I agree. On the cmake_example side, the main.cpp file should be updated to match the one from python_example. With the docstrings in place, the sphinx docs folder could also be added.

In the other direction, if you are open to it, I believe that the .travis.yml and .appveyor.yml files from cmake_example could be added to python_example. The installation procedures are identical so the CI configs would not require any changes. Although, those only test pip install, since I haven't gotten around to setting up Travis and AppVeyor for the conda recipe. But I'd like to include a test for that as well.

There is a little bit of divergence with regard to Windows: because CMake will internally pick the latest VS version and set the environment appropriately, there is no need to manually call vcvarsall.bat. I assume this would also be the case for the conda recipe in cmake_example, so those lines probably can be removed. But as I said, I have not yet gotten around to testing this.

from cmake_example.

SylvainCorlay avatar SylvainCorlay commented on August 31, 2024

I agree. On the cmake_example side, the main.cpp file should be updated to match the one from python_example. With the docstrings in place, the sphinx docs folder could also be added.

👍

In the other direction, if you are open to it, I believe that the .travis.yml and .appveyor.yml files from cmake_example could be added to python_example. [...]

Yes, that is a good idea.

There is a little bit of divergence with regard to Windows: because CMake will internally pick the latest VS version and set the environment appropriately, there is no need to manually specify vcvarsall.bat. [...]

Interesting.

from cmake_example.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.