Comments (3)
The projects should be in sync now with the bulk of the changes in #5 and pybind/python_example#14.
I don't expect any huge changes in the future, so the sync should be easy to maintain.
from cmake_example.
I agree. On the cmake_example
side, the main.cpp
file should be updated to match the one from python_example
. With the docstrings in place, the sphinx docs
folder could also be added.
In the other direction, if you are open to it, I believe that the .travis.yml
and .appveyor.yml
files from cmake_example
could be added to python_example
. The installation procedures are identical so the CI configs would not require any changes. Although, those only test pip install
, since I haven't gotten around to setting up Travis and AppVeyor for the conda recipe. But I'd like to include a test for that as well.
There is a little bit of divergence with regard to Windows: because CMake will internally pick the latest VS version and set the environment appropriately, there is no need to manually call vcvarsall.bat
. I assume this would also be the case for the conda recipe in cmake_example
, so those lines probably can be removed. But as I said, I have not yet gotten around to testing this.
from cmake_example.
I agree. On the cmake_example side, the main.cpp file should be updated to match the one from python_example. With the docstrings in place, the sphinx docs folder could also be added.
👍
In the other direction, if you are open to it, I believe that the .travis.yml and .appveyor.yml files from cmake_example could be added to python_example. [...]
Yes, that is a good idea.
There is a little bit of divergence with regard to Windows: because CMake will internally pick the latest VS version and set the environment appropriately, there is no need to manually specify vcvarsall.bat. [...]
Interesting.
from cmake_example.
Related Issues (20)
- Build requirements not working HOT 2
- How to cmake manually. HOT 1
- Feature request: ability to import in poetry Python shell HOT 1
- How to specify python? HOT 5
- Using pybind not as add_subdirectory... HOT 1
- `version` in `setup.py` is not working, need to set it inside `main.cpp` HOT 1
- How to build an executable while installing in normal and editable mode HOT 1
- Updating pybind and ImportError: dynamic module HOT 5
- how to build with arm-linux-gcc HOT 1
- How to properly include CUDA?
- Cannot install this example from pypi test HOT 5
- Copy DLL to Python site packages HOT 8
- Generating .whl file possible? HOT 1
- CMAKE_ARGS for building for conda-forge HOT 2
- Build fails with pybind11 2.7 HOT 21
- running "pip install ./cmake_example" will install the shared library into site-packages root folder, but not a dedicated subfolder
- python file can't import module after change pybind target name
- module 'cmake_example' has no attribute 'add' HOT 1
- Failed to import cmake_example
- Error when building with Ninja HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cmake_example.