Giter Club home page Giter Club logo

Comments (4)

jessuppi avatar jessuppi commented on July 18, 2024

Possibly related issues linked below, at least other developers might land on them trying to debug this... I see dozens of others too, however just trying to get this Issue a bit of visibility.

#4640, #2219, #697, #397, #1365, #1418, #2123, #1375, #1935, #1132, #4558, #1610, #2712, #1266

from pwabuilder.

jgw96 avatar jgw96 commented on July 18, 2024

Hey @jessuppi do you have an example web manifest that this wordpress plugin generates? It sounds like it is not valid JSON from the error, but this would help us confirm.

from pwabuilder.

jessuppi avatar jessuppi commented on July 18, 2024

@jgw96

For the semi-official PWA plugin released by WordPress.org, the manifest URL is here:

/wp-json/wp/v2/web-app-manifest

I ran a few tests, with the Offline browsing option both enabled and disabled but the JSON output appeared the same. It could be a coincidence during my tests, maybe previously the output was NOT the same, but unlikely:

{"name":"Example Site","start_url":"https:\/\/example.com\/","display":"minimal-ui","dir":"ltr","short_name":"Example","lang":"en-US","background_color":"#fff","theme_color":"#fff","description":"My website is about cats","icons":[{"purpose":"any","src":"https:\/\/example.com\/wp-content\/uploads\/sites\/4\/2023\/12\/cropped-logo-512-192x192.png","sizes":"192x192","type":"image\/png"},{"purpose":"any","src":"https:\/\/example.com\/wp-content\/uploads\/sites\/4\/2023\/12\/cropped-logo-512.png","sizes":"512x512","type":"image\/png"}]}

It validates fine on JSONLint too.

The JSON output appears minified, but I think that is from Cloudflare. In any regard, the minification didn't seem to hurt anything because on subsequent attempts, PWA Builder packaging worked fine.

By the way, it might be related, I saw the problem on a WordPress Multisite installation. I haven't found any documentation or similar experiences to mine, so just wanted to share. The HTTP headers also appear to be the same both with Offline browsing enabled and disabled.

from pwabuilder.

jgw96 avatar jgw96 commented on July 18, 2024

Ahhhh, you mentioned Cloudflare, yeah this is probably minified from them. Another weird thing I noticed is those icon URLs don't seem to load correctly in my browser. Thanks for sharing this info, I am going to close this issue for now as you mentioned its working for you now, but again, thanks for the info!

from pwabuilder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.