Comments (3)
PuruVJ
commented on August 23, 2024
1
The code seems good to me. I kinda don't like the hard coded menu items, but who am I kidding really, no point in having object-based/dynamic context menu until we have some apps 😉. And we can always refactor it.
About the hoverable thing, it probably needs a sprinkle of z-index: 9999999 or something. Try that, and even if it doesn't work, no issues, I'll fix it by looking at the DOM 3D model.
Overall looks good to me. Please do send a PR. And a request: Before you do that, please run prettier on the files you changed/created 😄
from macos-preact.
PuruVJ
commented on August 23, 2024
Looks great. Can you push this code to your own fork's branch so I can take a look?
from macos-preact.
Deep-Codes
commented on August 23, 2024
Looks great. Can you push this code to your own fork's branch so I can take a look?
Yeah Context Menu
This is the most bare model implementation haven't used jotai yet and code is janky
Also why doesn't the hover work in the menu 👀
from macos-preact.
Related Issues (20)
- Auto-resize windows when viewport height/width change HOT 1
- Normal cursor on VSCode HOT 1
- Calculator blur effect doesn't work on Firefox. HOT 1
- Add "functional" Finder HOT 1
- Fix code splitting issues for apps HOT 1
- Focus bug of VSCode HOT 3
- package-lock.json and yarn.lock are ignored HOT 4
- Toggling Theme only works on clicking Moon Icons 🌖 HOT 2
- Magnification HOT 1
- Auto-Hide Dock
- update to pnpm instead npm + pwa HOT 1
- adshub HOT 1
- calcutor is not working propely HOT 2
- Hide cursor when "boot"
- Calendar Application - Phase 1 Month View
- Handle Cmd+W and Cmd+Q HOT 1
- macOS cursor doesn't work on all control panel button area HOT 1
- Bounce icon on app start HOT 5
- Use :global(body dark) instead of useTheme hook
- Accessible macOS Web
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from macos-preact.