traffic light icons on hover about macos-preact HOT 17 CLOSED

OMG!!!! Thank you!!! please do make a PR 🤩🤩

from macos-preact.

Feel free to rename the classes

from macos-preact.

I have no idea which of these do what except for the red one. Use your judgement 😁

from macos-preact.

Hi. Sorry for the inconvenience. I just merged a PR which changes TrafficLights component a bit. Could you pls git pull it and fix the merge conflicts, if any

from macos-preact.

Oh wait, this lone svg is causing issues. This will not be scoped

from macos-preact.

Yeah this would solve it:

.container {
  display: inline-flex;
  align-items: center;
  gap: 0.45rem;

  height: 100%;

  &:hover .trafficLight svg {
    visibility: visible;
  }
}

.trafficLight svg {
  visibility: hidden;
}

from macos-preact.

Fixed in #66

from macos-preact.

https://github.com/PuruVJ/macos-web/blob/969df8a3223f5c012143fcd2e7a12b0c06621058/src/components/Desktop/Window/TrafficLights.tsx#L21

I believe here thougth they seem to be in order the naming is not correct:

      <ButtonBase className={css.closeLight} onClick={closeApp} />
      <ButtonBase className={css.stretchLight} />
      <ButtonBase className={css.minimizeLight} />

closeLight -> Red Button
stretchLight -> Green Button
minimizeLight -> Yellow Button

Tho in styles they are styled correctly

and yes i am working on a PR on it ⚡️.

from macos-preact.

Alright let me see 👀

from macos-preact.

@PuruVJ there's a problem

PR merged: It's hiding icons

arent styles scoped?

from macos-preact.

Yes it is hiding styles for me too

from macos-preact.

They are scoped if you use CSS modules

from macos-preact.

Huh, it is CSS modules, but it is still hiding. Strange

from macos-preact.

No issues, I'll scope it. No big deal :)

from macos-preact.

Fixed. Will be live soon

from macos-preact.

Hi, Can I ask you your Twitter handle?

from macos-preact.

Hi, Can I ask you your Twitter handle?

Yeah sure it's @DeepankarBhade

from macos-preact.