SAM: can't connect to self about i2pd HOT 9 CLOSED

I would prefer to return CANT_REACH_PEER error in this case

from i2pd.

after discussion, Java I2P agrees with orignal that we should send CANT_REACH_PEER, and propose to make that change in our code unless somebody can come up with a good reason why we should support loopback

from i2pd.

I confirm this behaviour, with 2.50.1-8-g5cf1961f.

from i2pd.

Check for self address was added intentionally, with this commit: d81ca5f.

However, no one remember why it was needed to be done this way.

I tried to disable check here:

Connection established correctly, nothing exploded.

But I can't be sure that it is safe to make such change of course.

from i2pd.

I don't see a reason why a destination should be able to connect to itself. For testing purposes, just create two session. Hence this check was added to avoid some potential security breaches.

from i2pd.

Probably related:
qbittorrent/qBittorrent#10791
arvidn/libtorrent#7479

from i2pd.

cd08756

from i2pd.

I just thought i should report it because it also causes log spam with messages like "Remote LeaseSet not found" and "Can't send packets, missing remote LeaseSet, sSID=..."

from i2pd.

https://i2pgit.org/i2p-hackers/i2p.i2p/-/merge_requests/173

from i2pd.