Giter Club home page Giter Club logo

Comments (5)

Purfview avatar Purfview commented on August 26, 2024

Why not use a search url:
https://yts.mx/browse-movies/The Godfather/all/all/0/latest/1972/all

.

any way to fix this?

Could be fixed by changing this line:
var search_string = movie_title.trim().replace(/ +\(.*|&|:/g, '').replace(/\s+/g, space_replace);
To this:
var search_string = movie_title.trim().replace(/ +\(.*|&|:/g, '').replace(/\s+/g, space_replace).toLowerCase();

But maybe that would break a search on some other site[s]...

from imdb-scout-mod.

nzarbayezid avatar nzarbayezid commented on August 26, 2024

Why not use a search url: https://yts.mx/browse-movies/The Godfather/all/all/0/latest/1972/all

omg dude, I was blind the whole time I didn't see the Browse Movies section, thanks you are a lifesaver.

but one other question if you don't mind, I'm struggling with some sites that even they don't have the move title that I'm looking for the search result is still green, for example, this one, as you can see the title is long and of course there's no anime matching this title, but still, the search results still come back green, I treed matchRegex and loggedOutRegex but couldn't fixe it. is there any way to tell the code if the site has the exact title that I'm looking for comeback as green, if there was no matching title don't come back as a green, cuz I don't want any other title suggestion, or any way to fix this?

image

image

from imdb-scout-mod.

Purfview avatar Purfview commented on August 26, 2024

I'm struggling with some sites that even they don't have the move title that I'm looking for the search result is still green, for example, this one,...

If search returns random results then nothing you can do. And exact search string is just there in the search field... so, a title will be always matched.
Add such non-searchable sites to the icon sites section.

Btw, if you won't add sites with "Pull request" then your custom edits will disappear after update.

from imdb-scout-mod.

nzarbayezid avatar nzarbayezid commented on August 26, 2024

Btw, if you won't add sites with "Pull request" then your custom edits will disappear after update.

I spend houser customizing my custom sites, thanks's god that you mentioned that cuz I don't know what's "Pull request" and how to do it

If search returns random results then nothing you can do. And exact search string is just there in the search field... so, a title will be always matched. Add such non-searchable sites to the icon sites section.

I was thinking the same think when I said it, but there's one way around to avoid that, mabye they can add this kinda code to the script

'MatchedString': /%search_string%/, this line of code teel the script that we are looking for this String that we want to matched
'HowManyString': /2/ this line of code tells the search result if there are two or matched strings or higher than two the search will return green, if fewer than two return red, I don't know if that is doable or worth the effort.

from imdb-scout-mod.

Purfview avatar Purfview commented on August 26, 2024

I was thinking the same think when I said it, but there's one way around to avoid that, mabye they can add this kinda code to the script

'MatchedString': /%search_string%/, this line of code teel the script that we are looking for this String that we want to matched 'HowManyString': /2/ this line of code tells the search result if there are two or matched strings or higher than two the search will return green, if fewer than two return red, I don't know if that is doable or worth the effort.

But there are not 2, but exactly 69 matched strings, maybe tomorrow there will be 55 or 72...
Red is only for "search is not possible", for "not found" - yellow.

I don't know what's "Pull request" and how to do it.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requests
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request

Easiest way is just to press on "IMDb_Scout_Mod.user.js" and then Edit button.

from imdb-scout-mod.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.