Extend CoreFn's Int literal encoding with a stringified value about purescript HOT 8 OPEN

Not sure if this helps you, but yoga-json is able to parse BigInt by passing a reviver function to JSON.parse.

Reviver functions don’t help here because it’s already a JSON Number. Reviver functions can’t recover the original JSON syntax in order to load a Number as a BigInt without losing precision.

from purescript.

It's not possible for tools like purescript-backend-optimizer to parse CoreFn JSON for backends which use unbounded integers with any of the stock JSON tooling available in the PureScript ecosystem as they all rely on builtin JSON.parse.

Not sure if this helps you, but yoga-json is able to parse BigInt by passing a reviver function to JSON.parse.

from purescript.

@natefaubion You may be interested in the Stage 3 proposal JSON.parse source text access which makes this possible through revivers. Stage 3 means recommended for implementation, and it is already available in Chrome stable.

from purescript.

Very cool!

from purescript.

@natefaubion You may be interested in the Stage 3 proposal JSON.parse source text access which makes this possible through revivers. Stage 3 means recommended for implementation, and it is already available in Chrome stable.

I still think it would be easier to just encode the value as a String.

from purescript.

@natefaubion While this issue is for an Integer value, should the same be done on a Number value, too?

from purescript.

I don't think so. Number values are Double which are IEEE floats, same as JS, so there's no precision issue.

from purescript.

This might be a slightly different incarnation of this issue I just came across while compiling the integers test suite using backend-optimizer (thus using corefn as input). The PS literal -2147483648 gets compiled to (negate 2147483648). That positive number literal doesn't fit the 32-bit Integer once it's converted to int with 2147483648|0. Changing the JSON representation to a string wouldn't actually help if the negative literal gets compiled to negate x, the damage is already done in the corefn.

from purescript.