Giter Club home page Giter Club logo

Comments (2)

adrienthebo avatar adrienthebo commented on September 27, 2024

This requests a few features, I'll respond to them in turn.

Displaying the version of the module on disk as opposed to what's specified in the Puppetfile:

πŸ‘. I thought that I implemented things to show the currently installed version, but I must have been mistaken about that.

Displaying the module version/SHA:

This gets a little bit stickier. In theory I could see if any git tags matched the currently checked out branch, but that increases the complexity of this a bit. Cool feature, would be awesome to have, but I don't know how much this should be prioritized. πŸ‘ for the idea though.

Command layout:

For the sake of sanity, every action needs to be under a subcommand. For instance, the deploy actions that use an r10k.yaml are entirely different from the puppetfile actions. They use the same underlying behavior but they aren't necessarily joined. Thus, doing r10k puppetfile display is going to be different from r10k deploy display. Does that make more sense?

r10k deploy status

πŸ‘ for the subcommand name.

However, everything has to be complicated. :) To correctly show if a module is out of date, you would have to fetch the latest information - and if you're operating on a lot of modules, this could take a while. If nothing else, this should preserve deploy display or a similar command so that you can see the status of things without doing a fetch.

Should a status command have a flag to determine if everything should be fetched beforehand?

command output:

πŸ‘ for color.

Formatting:

I was just going to go with yaml formatting in the general case. Is the real distinction on whether it r10k should output color/no color?

Also, thanks very much for submitting this awesome issue report! I really appreciate feedback like this!

from r10k.

adrienthebo avatar adrienthebo commented on September 27, 2024

Support for module expected/actual versions added in bd7ea47:

ops (/home/adrien/development/r10k/testing/deploy/ops/environments)
    - add_mysql_error_logs
        modules:
            - git
                actual: 13b2b8f0e93f3304f4b13c546246da7b51e78173
                expected: 13b2b8f0e93f3304f4b13c546246da7b51e78173
                type: git
            - hubot
                actual: 1ab6921e70ee1656ca753ea8c5f9591e8472eedb
                expected: 1ab6921e70ee1656ca753ea8c5f9591e8472eedb
                type: git

It doesn't encompass all of the behavior asked for in this ticket but it gets us a lot closer. I'm going to ship 1.4.0 with this behavior so that something can get out of the door; if additional functionality is required then we can incrementally revisit this and extend behavior in future releases.

from r10k.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.