Giter Club home page Giter Club logo

Comments (7)

joeduffy avatar joeduffy commented on July 22, 2024

This definitely seems like a bug where we're accepting a string when only an Archive should be allowed. This would explain the odd diffing behavior.

from pulumi-gcp.

sylver avatar sylver commented on July 22, 2024

@joeduffy Ok, I see what you mean when looking into the method documentation.

How one is supposed to create/use an Archive in this case instead of a string then ?

Couldn't you accept a string and automatically create an Archive (whatever that is) from it under the hood to handle this simple case ?

from pulumi-gcp.

clstokes avatar clstokes commented on July 22, 2024

Per an internal conversation, source should be retyped to Asset rather than Archive. This should achieve the correct/expected behavior.

from pulumi-gcp.

lukehoban avatar lukehoban commented on July 22, 2024

See also pulumi/pulumi#280 which is sort of a root cause here.

from pulumi-gcp.

lukehoban avatar lukehoban commented on July 22, 2024

We should do a sweep of source properties that map to files on disk and ensure we have mapped them to Assets/Archives. It was raised recently that aws.lambda.Layer has a similar problem (we addressed this for aws.lambda.Function a long time ago). We'll also need to come up with a general strategy here on two fronts:

  1. How to make the change from source: string to something: Asset
  2. How to decide whether to accept Asset or Archive, and ideally how to ensure that we don't have to make this decision at all by fixing pulumi/pulumi#280.

Given how many commonly used APIs this impacts, would be great to tackle these sooner than later.

from pulumi-gcp.

jen20 avatar jen20 commented on July 22, 2024

This is fixed in #101, but we likely don't want to release it until after #106 is considered OK to go out, since it represents a breaking type change. Consequently, I'll move this to M22.

from pulumi-gcp.

jen20 avatar jen20 commented on July 22, 2024

This seems dependent on pulumi/pulumi#280, which is not currently assigned. For now I'll remove this from a milestone, though #101 should fix this when pulumi/pulumi#280 is dealt with.

from pulumi-gcp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.