Comments (7)
This definitely seems like a bug where we're accepting a string
when only an Archive
should be allowed. This would explain the odd diffing behavior.
from pulumi-gcp.
@joeduffy Ok, I see what you mean when looking into the method documentation.
How one is supposed to create/use an Archive
in this case instead of a string
then ?
Couldn't you accept a string
and automatically create an Archive
(whatever that is) from it under the hood to handle this simple case ?
from pulumi-gcp.
Per an internal conversation, source
should be retyped to Asset
rather than Archive
. This should achieve the correct/expected behavior.
from pulumi-gcp.
See also pulumi/pulumi#280 which is sort of a root cause here.
from pulumi-gcp.
We should do a sweep of source
properties that map to files on disk and ensure we have mapped them to Assets
/Archives
. It was raised recently that aws.lambda.Layer
has a similar problem (we addressed this for aws.lambda.Function
a long time ago). We'll also need to come up with a general strategy here on two fronts:
- How to make the change from
source: string
tosomething: Asset
- How to decide whether to accept
Asset
orArchive
, and ideally how to ensure that we don't have to make this decision at all by fixing pulumi/pulumi#280.
Given how many commonly used APIs this impacts, would be great to tackle these sooner than later.
from pulumi-gcp.
This is fixed in #101, but we likely don't want to release it until after #106 is considered OK to go out, since it represents a breaking type change. Consequently, I'll move this to M22.
from pulumi-gcp.
This seems dependent on pulumi/pulumi#280, which is not currently assigned. For now I'll remove this from a milestone, though #101 should fix this when pulumi/pulumi#280 is dealt with.
from pulumi-gcp.
Related Issues (20)
- Workflow failure: cron HOT 2
- Bug in Cloud SQL HOT 1
- Google Cloud - Client-based APIs and quota projects do not work well HOT 3
- Upgrade terraform-provider-google-beta to v5.31.1 HOT 3
- pulumi up causes Cloud Run domainMapping to be reset HOT 1
- Upgrade terraform-provider-google-beta to v5.32.0
- Refactor resources.go to handle iam docs
- Workflow failure: master HOT 3
- Malformed metadata.annotations pulumiLabels.% HOT 8
- Workflow failure: Check upstream upgrade HOT 1
- Workflow failure: master HOT 1
- Using `dailyRecurrence: {}` on `gcp.firestore.BackupSchedule` tries to constantly update the BackupSchedule resource HOT 4
- Upgrade terraform-provider-google-beta to v5.33.0
- Workflow failure: cron HOT 1
- PlanResourceChange issue with empty strings and GCP labels HOT 2
- PlanResourceChange GCP test failures HOT 8
- PlanResourceChange: Empty resource labels keeps old label value
- Workflow failure: master HOT 1
- SslMode does not exist in type Input<DatabaseInstanceSettingsIpConfiguration> HOT 2
- logConfig.filterExpr not interpolating properly when importing gcp.compute.Subnetwork HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pulumi-gcp.