DatabaseInstance replace logic seems wrong about pulumi-gcp HOT 8 CLOSED

That is unexpected - the underlying provider does not mark ipConfiguration or authorizedNetworks as ForceNew so changes to these should not be requiring replacement.

from pulumi-gcp.

Had the same issue with gcp.container.Cluster too when changing the nodeConfig, but I assumed this was expected behaviour as you can't change the default pool.

from pulumi-gcp.

Yes - for Cluster#nodeConfig it is currently expected that that would require replacement. The underlying reason is this: https://github.com/terraform-providers/terraform-provider-google/blob/51e63bfff2d2acba78bdbb35227669b820a4d61e/google/node_config.go#L26 is marked ForceNew, which I expect is ultimately a limitation in the GCP API (ClusterUpdate does not support updating NodeConfig).

But DatabaseInstance#settings does not require replacement (no ForceNew). So it's not clear why Pulumi would be suggesting you need to replace on changes here.

from pulumi-gcp.

It is possible to change the node config in the console however, and as far as I can see this does not replace the cluster as all the resources are restored on the new nodes.

from pulumi-gcp.

I suspect this is another case related to pulumi/pulumi-azure#182.

from pulumi-gcp.

Confirmed that this is another case of pulumi/pulumi-terraform#329.

From detailed logs - we see:

I0302 11:45:45.371898   58867 provider_plugin.go:303] Provider[gcp, 0xc0009600f0].Diff(urn:pulumi:dev::20190226::gcp:sql/databaseInstance:DatabaseInstance::master,master-aa68e7f) success: changes=2 #replaces=[region] #stables=[databaseVersion name masterInstanceName project] delbefrepl=false

In particular, the region property is what's actually triggering the replacement. As in the other cases in , this is:

			"region": {
				Type:     schema.TypeString,
				Optional: true,
				Computed: true,
				ForceNew: true,
			},

Closing this out and will track in that issue instead

from pulumi-gcp.

This is in fact another instance of the same class of TF bug seen in
pulumi/pulumi-aws#451. The schema for region that is present in the version of the GCP TF provider that this repo is locked to does not include the Computed property: https://github.com/terraform-providers/terraform-provider-google/blob/v1.20.0/google/resource_sql_database_instance.go#L58-L62

from pulumi-gcp.

Here's the TF issue:
hashicorp/terraform-provider-google#2554

from pulumi-gcp.