Giter Club home page Giter Club logo

Comments (5)

kylekatarnls avatar kylekatarnls commented on May 24, 2024 14

Hi,

Thanks for the report. Indeed, the equivalent syntax does not exist yet in pug-php. First remember that:

script(src="script.js")

is very often a better option since you benefit the browser cache.

For a complete and optimized way to handle your assets, I recommand you to use https://github.com/pug-php/pug-assets

Else, for the moment you can include a whole script:

include script

script.pug:

script.
  console.log('Foo bar');

from pug.

kylekatarnls avatar kylekatarnls commented on May 24, 2024 2

I realize our unit tests are no longer up to date, the original jade-php repository I forked:

script
  if (foo) {
    bar();
  }

No dot after script.
Now in pugjs/pug:

script.
  if (foo) {
    bar();
  }

The script and style logice changed.

Update this feature could cause regressions for anyone using raw script and no dot after the tag name, but it's the right way to match pugjs.

I will think about the best way to implement this.

from pug.

esiao avatar esiao commented on May 24, 2024

Thanks for the report. In this case I would just need to add the dot to match. The only reason why I would like to have my js as external javascript file is because of syntax highlight and eslint (in Atom).
The reason why I don't want to include it as a file is because it's a preloader script, inlining it assures me that it executes when I want it.

As for pug assets that's interesting (even more for the contact and minify options) but I'm not in a Symphony environment sadly. Thanks.

from pug.

kylekatarnls avatar kylekatarnls commented on May 24, 2024

Oh I see the error in the REAME. pug-assets is used by pug-symfony. But it can also be used without, I will fix the README. Note that pug-assets use pug-minify (a keyword that you can also use alone).

You can right now try the fix on the branch include-script (use the version "dev-include-script" in composer), this will be merged with the version 2.3.

from pug.

kylekatarnls avatar kylekatarnls commented on May 24, 2024

2.3 is released. Thanks again for your help.

from pug.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.