Giter Club home page Giter Club logo

Comments (7)

kylekatarnls avatar kylekatarnls commented on June 4, 2024 1

You can now upgrade to 2.0.0. Thanks.

from pug.

kylekatarnls avatar kylekatarnls commented on June 4, 2024

Confirmed. It's a regression, I add a test to keep this unbroken and will fix it as a priority.

from pug.

kylekatarnls avatar kylekatarnls commented on June 4, 2024

Hi, it should be fixed, please update and retry.

from pug.

kylekatarnls avatar kylekatarnls commented on June 4, 2024

I consider this issue as fixed, fell free to re-open it if you meet any problem.

from pug.

s4msung avatar s4msung commented on June 4, 2024

The next issue i run into because aria-haspopup is not a boolean attribute:

a.dropdown-toggle(href="#", data-toggle="dropdown", role="button", aria-haspopup="true", aria-expanded="false")

rendered:

<a href="#" data-toggle="dropdown" role="button" aria-haspopup class="dropdown-toggle"></a>

expected:

<a href="#" data-toggle="dropdown" role="button" aria-haspopup="true" aria-expanded="false" class="dropdown-toggle"></a>

Consider to maintain a list of boolean attributes like this kangax/html-minifier#63 (can't find a complete list in w3c specs) to handle the correct rendering

from pug.

kylekatarnls avatar kylekatarnls commented on June 4, 2024

Indeed, it's a big concern. I think, the most flexible way would be to differentiate true and "true" but the whitelist could be an easy quick fix. Thanks.

from pug.

kylekatarnls avatar kylekatarnls commented on June 4, 2024

It should be fixed now if you use dev-master branch, else it will be in 2.0.0.

from pug.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.