Giter Club home page Giter Club logo

Comments (14)

davemachado avatar davemachado commented on May 6, 2024 1

@mikestreety beat me to it.... 👍

from public-apis.

mikestreety avatar mikestreety commented on May 6, 2024

Hi @bkazi - If an API key is required it should say so. If there are any missing this is just a mistake.

Now that we've merged a load, are there any you know require a key which isn't specified?

from public-apis.

yannbertrand avatar yannbertrand commented on May 6, 2024

May we add a column to check if an api key is required (when not using OAuth)?

See #189

from public-apis.

mikestreety avatar mikestreety commented on May 6, 2024

I think that issue has some validity - changing oAuth to Auth means the "No but an apiKey is required can be changed to just apiKey

from public-apis.

yannbertrand avatar yannbertrand commented on May 6, 2024

Current solution:

API Description OAuth Link
API 1 API 1 Yes Go!
API 2 API 2 No, but an apiKey is required Go!
API 3 API 3 No Go!

Rename-oauth-column solution:

API Description Auth Link
API 1 API 1 OAuth Go!
API 2 API 2 apiKey Go!
API 3 API 3 No Go!

Add-a-column solution:

API Description Auth OAuth Link
API 1 API 1 Yes Yes Go!
API 2 API 2 Yes No Go!
API 3 API 3 No No Go!

I agree with @mikestreety, the second solution seems to be the neatest. What do think of it?

from public-apis.

jbrooksuk avatar jbrooksuk commented on May 6, 2024

Hmm, if we're to generate JSON from this data, then we want it to be as verbose as possible, right?

from public-apis.

mikestreety avatar mikestreety commented on May 6, 2024

I don't think we should let potential JSON-ification get in the way of readability? We could head down route two and then route three for the JSON and compile it into a route 2 looking table?

from public-apis.

davemachado avatar davemachado commented on May 6, 2024

Because this list of API's is publicly supported, I think the renaming the OAuth column to just Auth adds the opportunity to add a bit more detail into the method of authorization instead of just a blunt Yes/No. I would recommend this in hopes of keeping a consistent naming scheme so that we don't end up having variations of one type of Auth (apikey, ApiKey, Key, APIKEY, etc).

from public-apis.

mikestreety avatar mikestreety commented on May 6, 2024

We could add a "contributing" guide and include a list of existing ones so that several variations don't occur.

Are we looking to know that just an API Key is required? Is there any reason it's written apiKey? I assume that's the actual parameter name - but it seems to have malformed into a standard phrase

from public-apis.

davemachado avatar davemachado commented on May 6, 2024

To solve the issue of having multiple naming schemes for the same auth type, perhaps adding a table at the top of the README to explain the different choices for Auth would be best suited.

from public-apis.

mikestreety avatar mikestreety commented on May 6, 2024

There is one PR outstanding. Once merged I say let's go for this 👍

from public-apis.

davemachado avatar davemachado commented on May 6, 2024

I just opened a PR (#252) that adds a contributing guide to the project. I think it pretty much outlines what we are looking for in a submission (including the apiKey inconsistency), but if anyone has changes they'd like to propose, I'd be more than happy to add them in. :)

from public-apis.

mikestreety avatar mikestreety commented on May 6, 2024

This has also been resolved in the same PR 😄 Once merged we can finally get rid of this issue!

from public-apis.

mikestreety avatar mikestreety commented on May 6, 2024

Closing this as it is now resolved

from public-apis.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.