Giter Club home page Giter Club logo

Comments (4)

ippa avatar ippa commented on May 25, 2024

I got bitten by this as well #72 .. I think it's easily patchable.

from react-native-scrollable-tab-view.

ericraio avatar ericraio commented on May 25, 2024

@brentvatne @ippa @bastengao I created a pull request to solve this, what do you think?

#98

I was thinking we should just throw an error message, why use this library for only one tab?

from react-native-scrollable-tab-view.

ippa avatar ippa commented on May 25, 2024

@ericraio : While testing / developing you might have just one tab from time to time:

  • In my case, the first time I tested it out, I only created one tab and then had to dig around due to the crash
  • While developing you might have situations where you comment out buggy/expensive tabs and end up with only one for a certain period of time, the app shouldn't crash then

I can't see any downside to make it work with only 1 tab. The fix is probably supersimple as I mention in #72.

If we do end up with an errormessage -- "child elements" might not mean something to certain users. How about "tabs" or "tab views" to use the term the libraryname itself uses.

@brentvatne : any final say? :)

from react-native-scrollable-tab-view.

skv-headless avatar skv-headless commented on May 25, 2024

fixed here 2c5e05c

from react-native-scrollable-tab-view.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.