ptiz / bender Goto Github PK

https://github.com/Carthage/Carthage/blob/master/Documentation/Artifacts.md#cartfileprivate

It would be helpful if there will be a possibility to pass multiple paths for one field.

Swift Package Manager might become mainstream to manage 3rd party dependencies and it would be better to add support for Bender

According to README there is reference cycle between an item rule and an array rule for nested structures. It might be better to provide new way to validate recursive structures without memory leaks.

JSON Schema includes a few keywords for combining schemas together. There are special operators for it: 'allOf', 'anyOf', 'oneOf'. Need to add the similar features to Bender.

I.e.
public protocol Rule {
associatedtype V
func validate(_ jsonValue: AnyObject) throws -> V
func dump(_ value: V) throws -> AnyObject
}

There is an json object with "bottomLevelKey" = null.
Actual behavior of validation using testRule described below: validation fails.
Expected behavior: validation finishes successfully because testRule contains only .optional parameters.
let testRule = ClassRule(YourModel()).optional("topLevelKey", rule(StringRule, atPath: "bottomLevelKey")) { $0.value = $1 }

According to http://json-schema.org/latest/json-schema-validation.html there is the list of used validation categories for JSON (already supported items are marked ✔):

• validation of string instances;
• validation of numeric instances;
• regular expressions and patterns;
• default values for missing keywords;
• validation of container instances;
• validation keywords sorted by instance types;
• multiplyOf;
• maximum and exclusiveMaximum (for numeric items);
• minimum and exclusiveMinimum (for numeric items);
• maxLength and minLength (for stringified items);
• maxItems and minItems (for arrays);
• maxProperties and minProperties (for dictionaries);
• uniqueItems;
• required;
• enum;
• type;
• allOf;
• anyOf;
• oneOf;
• not;
• definitions;
• additionalProperties, properties and patternProperties;
• date-time;
• email;
• hostname / ipv4 / ipv6 / uri /

Bender may support all of them by default. If something cannot be added into framework for any reasons need to implement examples of its usage.

Please add support of the Swift 5.1

It needs just two small fixes to succeed.

JSON Patch has specific notation, amount of the different operations is limited. Special Bender rules/another mechanism for applying PATCH operations to model objects will be helpful.

Like this:

let passString = try! StringifiedJSONRule(nestedRule: passportRule).dump(pass) as! String
expect(passString).to(equal("{\"valid\":false,\"issuedBy\":\"One\",\"number\":null}"))