Giter Club home page Giter Club logo

Comments (7)

vilhelmprytz avatar vilhelmprytz commented on June 10, 2024

Since you did not fill out the default information: is this the daemon or panel script?

Panel script does not use sudo for Debian, perhaps there are some I left out for the daemon script.

from pterodactyl-installer.

theraw avatar theraw commented on June 10, 2024

panel installation went well,

daemon failed like docker ps says docker not found

from pterodactyl-installer.

vilhelmprytz avatar vilhelmprytz commented on June 10, 2024

It looks like line 212 and line 206 have this problem. Would you like to remove the sudo from these two lines and send them in as a pull request?

from pterodactyl-installer.

theraw avatar theraw commented on June 10, 2024

i think it's better to install it

from pterodactyl-installer.

vilhelmprytz avatar vilhelmprytz commented on June 10, 2024

As you mentioned, it's really quite unnecessary to use sudo at all since the script itself requires root before it even begins running. I'd say it's more clean to remove the sudo commands but I am happy to rethink that if you know there are any other particular reasons to keep it or where it is useful in other cases?

from pterodactyl-installer.

theraw avatar theraw commented on June 10, 2024

yeah no and idk,

i'll have to check out everything script executes and daemon executes in order to answer that

by installing it its like a quick fix it can be required in other cases since some ppl use sudo ... and don't check at the begin if is root or not example some official pterodactyl docs include sudo in their how-to https://pterodactyl.io/panel/0.7/getting_started.html#queue-listeners

from pterodactyl-installer.

vilhelmprytz avatar vilhelmprytz commented on June 10, 2024

Well, the script requires you to be logged in as root before it even executes so the sudo is redundant. The Pterodactyl project documentation can refer to sudo since each command is executed by the user separately. If anything goes wrong they can just rerun that specific command. With the script it runs everything in one go regardless of previous output, so the commands has to be correct.

from pterodactyl-installer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.